[HOLD for payment 2021-11-04] Default workspace image is not displayed if a invalid file is uploaded - Reported by: @akshayasalvi

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to workspace editor.
2. Upload a non image file (e.g a zip file)

Expected Result:

An error is displayed and the default image of the workspace is shown

Actual Result:

An error is displayed and the workspace image is blank

Workaround:

Navigating to another modal and back to the workspace editor shows the default image.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.7-3

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.226.mp4

Expensify/Expensify Issue URL:

Issue reported by: @akshayasalvi
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1633985168146100

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @marklouisdeshaun (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[flodnv]

cc @kevinksullivan @MitchExpensify do we want to remove the n6-hold on this one?

[parasharrajat]

@flodnv I think we need these polishes to be done quickly.

Proposal

1. I checked that even if Backend threw an error, we are proceeding to set the URL which is wrong.
   

   App/src/libs/actions/Policy.js

   Line 291 in c6570c9

   return;

This does not throw error and allow this statement to run

App/src/pages/workspace/WorkspaceSettingsPage.js

Line 101 in c6570c9

this.setState({avatarURL: url}, resolve);

.

To fix this

1. We should throw an error in UploadAvatar in non 200 and remove the growl from there.
2. Now update the 'uploadAvatar' in the component
   a. resetting the image in the catch by this statement

            this.setState({previewAvatarURL: ''});

[MelvinBot]

@marklouisdeshaun Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kevinksullivan]

Removing N6 hold as this is relevant to the N6 use case.

[flodnv]

@marklouisdeshaun can you please export this job to Upwork so we can hire @parasharrajat ?

[marklouisdeshaun]

Created a job in Upwork!

Internal: https://www.upwork.com/ab/applicants/1450176894484250624/job-details
External: https://www.upwork.com/jobs/~018297ba091d0a48e5

[MelvinBot]

Triggered auto assignment to @Jag96 (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Jag96]

@parasharrajat I've sent the offer via Upwork, feel free to get started on a PR

[dylanexpensify]

taking over for Mark!

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.10-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• chg: Workspace Edit Page #5271

If no regressions arise, payment will be issued on 2021-11-04. 🎊

[akshayasalvi]

@dylanexpensify While resolved by somebody else, there would be a payment for reporting this one right?

[dylanexpensify]

Correct @akshayasalvi! Once we pay out for the issue being completed, we'll also pay out the reporting bonus to you 😄

[dylanexpensify]

@parasharrajat sent payment and closed contract!

@akshayasalvi can you please apply to this so we can hire/pay out your reporting bonus? :) https://www.upwork.com/jobs/~01567cf1bb91247d9c

[akshayasalvi]

@dylanexpensify Done

[dylanexpensify]

@akshayasalvi sent offer!

[dylanexpensify]

@akshayasalvi payment sent! Job closed, contract ended