Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split bill - Text is distorted in Spanish #6078

Closed
mvtglobally opened this issue Oct 27, 2021 · 7 comments
Closed

Split bill - Text is distorted in Spanish #6078

mvtglobally opened this issue Oct 27, 2021 · 7 comments
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review

Comments

@mvtglobally
Copy link

mvtglobally commented Oct 27, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com
  2. Log in with Spanish account (or, sign in to the same account through staging.expensify.com and use NVP.set('preferredLocale', 'es') and then refresh your New Expensify page)
  3. Click FAB + > Dividir factura (Split bill)
  4. Enter amount and click Next
  5. Select the person to split with, then Next

Expected Result:

Text must be clear

Actual Result:

Text is distorted in Spanish

Workaround:

n/a

Platform:

Where is this issue occurring?

  • iOS
  • Android
  • Mobile Web

**Version Number:1.1.10-0
**Reproducible in staging?:Y
**Reproducible in production?:Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Engineering Daily KSv2 labels Oct 27, 2021
@MelvinBot
Copy link

Triggered auto assignment to @HorusGoul (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@MelvinBot
Copy link

Triggered auto assignment to @conorpendergrast (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 27, 2021
@HorusGoul HorusGoul added the External Added to denote the issue can be worked on by a contributor label Oct 27, 2021
@MelvinBot
Copy link

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@HorusGoul HorusGoul removed their assignment Oct 27, 2021
@conorpendergrast
Copy link
Contributor

I updated the reproduction steps because they were missing setting the language, and missing that you have to select the person to split with.

I've tried to reproduce on iOS mobile web in Safari and Chrome, and haven't been able to reproduce (the text displays correctly, and doesn't overlap).

@HorusGoul Were you able to reproduce this? On what platform?

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Oct 28, 2021

I noticed some bizarre formatting with the text in English as well for a few of the Enable Payment Flow steps. Gonna investigate all the steps and make sure everything displays correctly in both English and Spanish.

@jasperhuangg
Copy link
Contributor

Ah, it's because our TextLink implementation prevents the text within the component from breaking to a new line, since under the hood Pressable is implemented with a View.

Here's how it looks if I get rid of Pressable and use Text instead to wrap:
Screen Shot 2021-10-28 at 11 47 41 AM

The only issue with this new implementation is that we'll lose the ability to apply styles to the text when it's hovered over or pressed on (which is why we were using Pressable before). However, I think this is a necessary tradeoff to format the text correctly into lines.

@stephanieelliott
Copy link
Contributor

Hey @jasperhuangg, it seems like #6113 fixes this issue, yeah? If so, put the brakes on moving this to Upwork.

@jasperhuangg jasperhuangg added the Reviewing Has a PR in review label Oct 29, 2021
@botify botify closed this as completed Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants