[HOLD for payment 2021-12-06] IOU - Double quote displays as HTML code in IOU request

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open https://staging.new.expensify.com/
2. Login with existing account
3. Tap + button
4. Select Split Bills
5. Select contact with double-quote in the name
6. Tap Request

Expected Result:

Contact name should display properly on IOU screen

Actual Result:

Double quote displays as HTML code in IOU request

Workaround:

Visual

Platform:

Where is this issue occurring?

• Web
• Mobile Web

Version Number: 1.1.12-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:

Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[parasharrajat]

Proposal

There are two ways we can do this.

1. Either backend unescape the string before sending it to frontend. ( I am not sure if that is safe to do).
2. We un-escape it before showing it on UI. This can be done in

   App/src/components/ReportActionItem/IOUQuote.js

   Line 38 in 6299f48

   {fragment.text}

like

 {Str.htmlDecode(fragment.text)}

[bfitzexpensify]

Upwork job

[MelvinBot]

Triggered auto assignment to @puneetlath (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MuhammadNasirr]

Proposal
here is how we can do this.

we can use the parseInt method the remove Double Quotes

parseInt((fragment.text.replace('"','')))

[muluwork-shegaw]

it would be a better to use regex to replace the quote in the string fragment.text.replace(/['"]+/g, '')

[puneetlath]

@bfitzexpensify I like @parasharrajat's option 2.

[puneetlath]

This has been merged. @parasharrajat thanks for your patience!

@bfitzexpensify please make sure to add the bonus for the company offsite hold when paying this out.

[bfitzexpensify]

Contrct ended and bonus added - thanks @parasharrajat.

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.16-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Unescape the backend strings for IOU #6184

If no regressions arise, payment will be issued on 2021-12-06. 🎊