-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging label isfloating right instead of 8px right to the ´Chat´ header #6297
Comments
Triggered auto assignment to @bondydaa ( |
A ProposalWe can simply fix this by removing the Line 25 in 6701446
It can simply be View without styling as the default axis for View is column in RN.
|
looks the discussion is happening https://expensify.slack.com/archives/C01GTK53T8Q/p1636732354165700 there might be more issues with some styles as well. Not sure if we need 1 big GH track them all or if we just want to create GHs as they pop up. |
Going to assign to Marco, our SOP is to typically have the engineer fix whatever they broke but this could probably also go to a contributor as well. |
I created this PR to fix the label position. I added that View before for the VBA step counter, I tested the solution and look good in both places (badge and step counter): |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Staging label is floating left 8px right to the ´Chat´ header
Actual Result:
Staging label is floating right instead of 8px right to the ´Chat´ header
Workaround:
None needed, visual issue.
Platform:
Where is this issue occurring?
Version Number: 1.1.14-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1636732354165700
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: