Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - 1.1.15-1 - Login - Continue button not visible when keyboard is opened #6325

Closed
mvtglobally opened this issue Nov 16, 2021 · 11 comments
Closed
Assignees

Comments

@mvtglobally
Copy link

mvtglobally commented Nov 16, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open app while not logged in
  2. Input any email and tap continue

Expected Result:

Password input and continue button and go backlink should be over the keyboard.

Actual Result:

Continue button and go back are not seen over the keyboard, but behind it
Issue is more prominent on mWeb, on the app modal does move up a bit

Workaround:

unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android
  • Mobile Web

Version Number: 1.1.15-1
*Reproducible in staging?: Yes *
**Reproducible in production?:No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Discovered when testing #6203

**Expensify/Expensify Issue URL:** **Issue reported by:** **Slack conversation:**

View all open jobs on GitHub

@mvtglobally mvtglobally added DeployBlockerCash This issue or pull request should block deployment AutoAssignerTriage Auto assign issues for triage to an available triage team member Engineering Daily KSv2 labels Nov 16, 2021
@MelvinBot
Copy link

Triggered auto assignment to @nickmurray47 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@MelvinBot
Copy link

Triggered auto assignment to @sakluger (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Nov 16, 2021
@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Nov 16, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@nickmurray47
Copy link
Contributor

nickmurray47 commented Nov 16, 2021

Where is this issue occurring?
Mobile Web

Can we get some specifics on screen size or device @mvtglobally? I tried reproducing on iPhone XR and did not have any issues with keyboard placement when entering my email or password.

I think I'm inclined to say this is not a deploy blocker

@parasharrajat
Copy link
Member

I think this already exists in production and never worked before. So no deploy blocker IMO.

@nickmurray47
Copy link
Contributor

Going to apply appropriate labels and put into pool

@nickmurray47 nickmurray47 added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 16, 2021
@nickmurray47 nickmurray47 removed their assignment Nov 16, 2021
@sakluger
Copy link
Contributor

I also can't reproduce this on my iPhone XS, either on the mobile app (using STG) or on mobile web. @parasharrajat you said that this behavior exists in production - does that mean that you're able to reproduce?

@parasharrajat
Copy link
Member

@sakluger I can reproduce this on Android M-web. It is native behaviour though. In android, only text input are moved above the keyboard.

@mvtglobally
Copy link
Author

Issue not reproducible during KI retests. (First week)

@mvtglobally
Copy link
Author

Issue not reproducible during KI retests. (Second week)

@mvtglobally
Copy link
Author

Issue not reproducible during KI retests. (Third week) Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants