Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Password form in new user signup journey hangs if submitted with enter key. #6389

Closed
anthony-hull opened this issue Nov 22, 2021 · 18 comments
Assignees

Comments

@anthony-hull
Copy link
Contributor

Action Performed:

  1. Sign up for a new account.
  2. Click the link sent to your email.
  3. enter a valid password
  4. Submit the form using Return on your keyboard

Expected Result:

App should load into your account.

Actual Result:

Submit button spins for ever, app hands at this point.
ValidateEmail and SetPassword api calls fire.

Workaround:

Refresh the page enter the password and try again, but clicking the button instead of pressing enter.
User would also be able to log in normally after this (but they wouldn't know this) as the necessary backend calls do fire.

Platform:

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
Reproducible in staging?:
Reproducible in production?:
yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
https://expensify.slack.com/archives/C01GTK53T8Q/p1636651198129600

View all open jobs on GitHub

@anthony-hull anthony-hull added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Nov 22, 2021
@MelvinBot
Copy link

Triggered auto assignment to @kadiealexander (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Nov 22, 2021
@kadiealexander
Copy link
Contributor

kadiealexander commented Nov 23, 2021

I wasn't able to produce this in the production environment (it works perfectly):

2021-11-24_09-31-06.mp4

But I experienced this earlier in the staging environment so I tested creating an account in staging.new.expensify.com and although the magic sign-in link isn't on staging, I still experienced the issue:

2021-11-24_09-33-36.mp4

@kadiealexander kadiealexander removed their assignment Nov 23, 2021
@MelvinBot
Copy link

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@MariaHCD
Copy link
Contributor

Wasn't able to reproduce on dev, staging or production 🤔 @anthony-hull Could you let me know which email you were facing this issue with? Perhaps there was an error on the backend.

@anthony-hull
Copy link
Contributor Author

hullo2u+doesitworkwithenter@gmail.com I believe! 😆

@MariaHCD
Copy link
Contributor

No errors on the backend. This issue looks similar to #5625 and https://github.com/Expensify/Expensify/issues/178687. It looks like the issue cannot be reproduced reliably. @anthony-hull Did you notice any JS errors in the console?

@anthony-hull
Copy link
Contributor Author

yes. I see the same console error. But I get it every single time I navigate the form with a keyboard. It's very consistent for me.

I can log in after, so the account is being setup correctly.
image

ValidateEmail response:
{
"accountID": 10924688,
"authToken": "REDACTED",
"email": "hullo2u+doesitworkwithenter2@gmail.com",
"httpCode": 200,
"jsonCode": 200,
"authResponseMessage": "200 OK",
"userHasSetPassword": false,
"requestID": "6b3a5a1eae31770e-MCI"
}

ChangePassword response:
{
"jsonCode": 200,
"requestID": "6b3a5a22fdca770e-LHR"
}

@MelvinBot
Copy link

@MariaHCD Huh... This is 4 days overdue. Who can take care of this?

@MelvinBot
Copy link

@MariaHCD 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@MariaHCD
Copy link
Contributor

MariaHCD commented Dec 6, 2021

Thanks for the additional info, @anthony-hull! Would you mind sending along a video of your test and the console error(s) that you receive?

@MelvinBot MelvinBot added Overdue and removed Overdue labels Dec 6, 2021
@MariaHCD MariaHCD added the Weekly KSv2 label Dec 9, 2021
@MelvinBot MelvinBot removed the Overdue label Dec 9, 2021
@MariaHCD MariaHCD removed the Daily KSv2 label Dec 9, 2021
@MariaHCD
Copy link
Contributor

Will try to reproduce this issue again next week

@MariaHCD
Copy link
Contributor

MariaHCD commented Jan 3, 2022

Hey, @anthony-hull! Just catching up on the issue linked above, it sounds like this issue is the same and the fix will be handled as part of #6587? Let me know!

@MelvinBot MelvinBot removed the Overdue label Jan 3, 2022
@anthony-hull
Copy link
Contributor Author

Yes you're correct :) I'm just waiting for another PR to merge!

@MariaHCD
Copy link
Contributor

MariaHCD commented Jan 3, 2022

Great, thanks for confirming! I believe we can close this issue out, then.

@MariaHCD MariaHCD closed this as completed Jan 3, 2022
@anthony-hull
Copy link
Contributor Author

anthony-hull commented Jan 3, 2022

If this closes out do I still get the bonus for reporting when the other issue closes? As the other issue is the duplicate

@MariaHCD
Copy link
Contributor

MariaHCD commented Jan 3, 2022

Great question, I'll just confirm with a colleague on this and get back to you asap.

@MariaHCD
Copy link
Contributor

MariaHCD commented Jan 4, 2022

Hey, @anthony-hull! Just double checked this for you. Since this issue did not actually identify the root cause of the bug and the issue was not fixed here, no reporting bonus will be paid out for this issue, unfortunately.

@anthony-hull
Copy link
Contributor Author

ok! thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants