-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Password form in new user signup journey hangs if submitted with enter key. #6389
Comments
Triggered auto assignment to @kadiealexander ( |
I wasn't able to produce this in the production environment (it works perfectly): 2021-11-24_09-31-06.mp4But I experienced this earlier in the staging environment so I tested creating an account in staging.new.expensify.com and although the magic sign-in link isn't on staging, I still experienced the issue: 2021-11-24_09-33-36.mp4 |
Triggered auto assignment to @MariaHCD ( |
Wasn't able to reproduce on dev, staging or production 🤔 @anthony-hull Could you let me know which email you were facing this issue with? Perhaps there was an error on the backend. |
hullo2u+doesitworkwithenter@gmail.com I believe! 😆 |
No errors on the backend. This issue looks similar to #5625 and https://github.com/Expensify/Expensify/issues/178687. It looks like the issue cannot be reproduced reliably. @anthony-hull Did you notice any JS errors in the console? |
yes. I see the same console error. But I get it every single time I navigate the form with a keyboard. It's very consistent for me. I can log in after, so the account is being setup correctly. ValidateEmail response: ChangePassword response: |
@MariaHCD Huh... This is 4 days overdue. Who can take care of this? |
@MariaHCD 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
Thanks for the additional info, @anthony-hull! Would you mind sending along a video of your test and the console error(s) that you receive? |
Will try to reproduce this issue again next week |
Hey, @anthony-hull! Just catching up on the issue linked above, it sounds like this issue is the same and the fix will be handled as part of #6587? Let me know! |
Yes you're correct :) I'm just waiting for another PR to merge! |
Great, thanks for confirming! I believe we can close this issue out, then. |
If this closes out do I still get the bonus for reporting when the other issue closes? As the other issue is the duplicate |
Great question, I'll just confirm with a colleague on this and get back to you asap. |
Hey, @anthony-hull! Just double checked this for you. Since this issue did not actually identify the root cause of the bug and the issue was not fixed here, no reporting bonus will be paid out for this issue, unfortunately. |
ok! thanks :) |
Action Performed:
Expected Result:
App should load into your account.
Actual Result:
Submit button spins for ever, app hands at this point.
ValidateEmail and SetPassword api calls fire.
Workaround:
Refresh the page enter the password and try again, but clicking the button instead of pressing enter.
User would also be able to log in normally after this (but they wouldn't know this) as the necessary backend calls do fire.
Platform:
Version Number:
Reproducible in staging?:
Reproducible in production?:
yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
https://expensify.slack.com/archives/C01GTK53T8Q/p1636651198129600
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: