Secondary log in - Extra gap under validation button - Reported by: @parasharrajat

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to Settings
2. Click on profile
3. Click on add phone number (secondary log in)
4. Check the button with dev tools

Expected Result:

Button area should only be consistent all around the button

Actual Result:

There's a empty gap below the button.

Workaround:

None needed, visual issue.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.16-6

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1637656551367400

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

Proposal

1. Remove the Extra margin from the button. Padding is already applied from the FixedFooter component around it.

   App/src/pages/settings/AddSecondaryLoginPage.js

   Line 152 in 03f1e76

   style={[styles.mb2]}

[deetergp]

Can be external and @parasharrajat's proposal takes care of it.

[MelvinBot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[jliexpensify]

Posted and invited @parasharrajat

https://www.upwork.com/ab/applicants/1463645267709853696/job-details
https://www.upwork.com/jobs/~01bdfa8ccd102ca443

[deetergp]

Approved 👍

[MelvinBot]

@deetergp, @jliexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[deetergp]

Not overdue.

[jliexpensify]

@deetergp just wanted to confirm for payment tomorrow:

It sounds like this is very similar to #6497

Am I paying Rajat $250 + $250 (bonus for reporting)? Or are we merging payment of the jobs together for Rajat?

Just want to make sure I'm not making a mistake and Rajat is getting paid accordingly, cheers!

[parasharrajat]

My thoughts 20 cents 💸 .
This issue was reported earlier and solved in a different PR than 6497. 6497 was not discovered during this issue and it's possible that it was caused by some changes later on. PR for 6497 is just merged today.
Although, they sound similar they are talking about changes on two different pages. Both issues were reported separately and both of them will have separate PR. So I consider them separate.

But in the end, it's your call.

[deetergp]

I agree with @parasharrajat — though they have a very similar fix, they are separate issues and should be treated as such.

[jliexpensify]

Great, thanks for clearing that one up gents! Will pay Rajat $500 then.

[MelvinBot]

@deetergp, @jliexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jliexpensify]

Got it in my calendar to pay tomorrow.

[jliexpensify]

Paid + bonus, closed!