Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android & iOS - Manage members screen is blank #6528

Closed
isagoico opened this issue Nov 30, 2021 · 29 comments
Closed

Android & iOS - Manage members screen is blank #6528

isagoico opened this issue Nov 30, 2021 · 29 comments
Assignees
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@isagoico
Copy link

isagoico commented Nov 30, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app in a Android or iOS device
  2. Navigate to Edit Workspace settings
  3. Click on manage members

Expected Result:

Manage members screen is fully rendered

Actual Result:

Manage members screen is blank on mobile devices.

Workaround:

None found in Android / iOS.

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.1.17-0

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @Santhosh-Sellavel
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1638132040029300

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@tgolen tgolen added the External Added to denote the issue can be worked on by a contributor label Nov 30, 2021
@MelvinBot
Copy link

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Dec 1, 2021

Hum, I don't see the same thing on my NewDot app - here are the steps I took

  1. Open the app on iOS device
  2. Tap my my profile > tap C.dobrzyn's workspace
  3. Tap on manage members and I see my admin displayed:

Running v1.1.17-4

@Santhosh-Sellavel can try again with an update version - v1.1.17-4 - to see if you see the same thing?

@Santhosh-Sellavel
Copy link
Collaborator

Santhosh-Sellavel commented Dec 1, 2021

Yep working fine, I was able to reproduce in version 1.1.17.2 or earlier!

But it was handled in latest build?

@Christinadobrzyn
Copy link
Contributor

Ah great! It seems like there have been several updates over the past 24 hours so I assume something in those updates resolved this. However, I remember always seeing the admin in the previous version so maybe something was in the middle of an update when you caught this.

We're good to close this?

@Santhosh-Sellavel
Copy link
Collaborator

Its good that its resolved now, we can close this one!

@isagoico
Copy link
Author

isagoico commented Dec 2, 2021

Reopening this - This is still happening on Android app on version 1.1.17-4

@isagoico isagoico reopened this Dec 2, 2021
@isagoico isagoico changed the title iOS / Android - Manage members screen is blank Android - Manage members screen is blank Dec 2, 2021
@Santhosh-Sellavel
Copy link
Collaborator

Yep, it is still reproducible. My bad I didn’t verify in android earlier!

@Christinadobrzyn
Copy link
Contributor

Ah, thanks for clarifying @isagoico and @Santhosh-Sellavel!

Created Upwork job
Internal - https://www.upwork.com/ab/applicants/1466605040031260672/job-details
External - https://www.upwork.com/jobs/~01c043b2222fa54500

Hired @Santhosh-Sellavel for reporting - waiting on proposals for the fix!

@MelvinBot
Copy link

Triggered auto assignment to @parasharrajat (Exported)

@MelvinBot MelvinBot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 3, 2021
@MelvinBot
Copy link

Current assignee @tgolen is eligible for the Exported assigner, not assigning anyone new.

@Santhosh-Sellavel
Copy link
Collaborator

Issue occurs again in iOS again in version 1.1.17.5 @puneetlath reported in slack thread

@parasharrajat
Copy link
Member

It seems that getFullPolicy

Policy.loadFullPolicy(policyID);
call is failing for some reason. I am not able to inspect the request in the network. Or don't know how to do that in Flipper.

@isagoico isagoico added the DeployBlockerCash This issue or pull request should block deployment label Dec 7, 2021
@github-actions github-actions bot removed the Weekly KSv2 label Dec 7, 2021
@github-actions github-actions bot added the Hourly KSv2 label Dec 7, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2021

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@isagoico
Copy link
Author

isagoico commented Dec 7, 2021

Adding the deploy blocker here - this issue is failing PR #6542 in the current regression checklist for iOS and Android.

@tgolen
Copy link
Contributor

tgolen commented Dec 7, 2021

I'm a little confused. That PR is linked to a different issue: #6287. Was this issue marked as a blocker by mistake?

@isagoico
Copy link
Author

isagoico commented Dec 7, 2021

@tgolen Nope. Marked this issue as deploy blocker because it's completely blocking us from verifying QA on iOS and Android for this PR #6287.

We usually mark issues that are blocking and/or failing the QA of PRs as deploy blockers.

@tgolen
Copy link
Contributor

tgolen commented Dec 7, 2021

Oh! I understand now. Got it. Looks like we're still looking for proposals to fix this.

@tgolen tgolen added Daily KSv2 and removed Hourly KSv2 labels Dec 7, 2021
@marcaaron marcaaron changed the title Android - Manage members screen is blank Android & iOS - Manage members screen is blank Dec 7, 2021
@Jag96
Copy link
Contributor

Jag96 commented Dec 7, 2021

It looks like the employeeList that is being sent back is different on iOS/Android compared to web. On web, the employeeList contains all the employees but on mobile it does not, it just contains the user email. I looked into the logs for this and it seems like the Get request we make for policyIDList in this call is coming up as an empty string on the API side when called from mobile, but when it is called from web it is the correct value.

I'm not sure what is causing this yet, but there's a chance it requires a back end fix so leaving some internal logs here:

@marcaaron
Copy link
Contributor

marcaaron commented Dec 7, 2021

also verified that the data here is an empty array on Android:

const data = _.chain(policyEmployeeList)

But not on web.

@marcaaron
Copy link
Contributor

Can see the employeeList getting returned in Flipper when making the request on Android:

2021-12-07_12-31-10

@marcaaron marcaaron assigned marcaaron and unassigned tgolen and parasharrajat Dec 7, 2021
@marcaaron marcaaron added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Dec 7, 2021
@marcaaron marcaaron added the Reviewing Has a PR in review label Dec 7, 2021
@Jag96 Jag96 removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 7, 2021
@Jag96
Copy link
Contributor

Jag96 commented Dec 7, 2021

Removed the posting from Upwork since this is being handled internally

@botify botify closed this as completed Dec 7, 2021
@Santhosh-Sellavel
Copy link
Collaborator

This qualifies for reporting bonus right?
@Jag96 or @Christinadobrzyn

@Jag96
Copy link
Contributor

Jag96 commented Dec 8, 2021

@Santhosh-Sellavel correct! I've created an upwork posting for that here and hired you for the job!

@Santhosh-Sellavel
Copy link
Collaborator

Thanks! @Jag96

@Christinadobrzyn
Copy link
Contributor

I'll keep an eye on this PR and pay @Santhosh-Sellavel at our 7 day after production payment timeframe.

@Santhosh-Sellavel
Copy link
Collaborator

Santhosh-Sellavel commented Dec 9, 2021

I just noticed, there are two active contracts for the same job. cc: @Christinadobrzyn Can you end one contract?
Screenshot 2021-12-09 at 7 44 11 AM

@Christinadobrzyn
Copy link
Contributor

Thanks for letting me know @Santhosh-Sellavel! I think I cancelled one of the contracts but Upworks isn't loading to show which one was cancelled. You might get a message in Upwork about it.

Either way, I will track both of these and make sure to pay you for one of them after the production deployment.

@Christinadobrzyn
Copy link
Contributor

Hey @Santhosh-Sellavel sorry for the delay with this - I just paid you for reporting this in this job. Thanks!

https://www.upwork.com/ab/applicants/1466605040031260672/job-details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

10 participants