Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2021-12-10 #6703

Closed
38 tasks done
OSBotify opened this issue Dec 10, 2021 · 22 comments
Closed
38 tasks done

Deploy Checklist: New Expensify 2021-12-10 #6703

OSBotify opened this issue Dec 10, 2021 · 22 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Dec 10, 2021 •
edited by roryabraham
Loading

Release Version: 1.1.20-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

cc @Expensify/applauseleads
@MelvinBot
Copy link

📣 @applausebot You have been assigned to this job by @OSBotify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Dec 10, 2021
@mvtglobally
Copy link

Starting QA

@mountiny
Copy link
Contributor

I am demoting the Workspace settings - app orientation issue from deploy blockers. It is a new and expected behaviour. Please, @mvtglobally could you update the testing so that we test the orientation change is possible on tablets, but we cannot change to landscape on mobile? Thank you!

Also I am removing the Chat - Messages that are bigger than 10240 characters from the deploy blocker list, it is a duplicate of an existent issue, which apparently was not solved as expected and I have informed the author of the PR. As it is already bug on production for a while it should not block the deploy.

@isagoico
Copy link

Regression is finished!
Issues found:

  1. Error message ''A room with this name already exist'' isn't displayed after type the same name for room the Room Name input #6709 is failing Add the NewRoomPage #6314
  2. Chat - Message that are bigger than 10240 characters does not appear without reload #6710 - Not a deploy blocker
  3. Workspace settings - App's orientation does not change to Landscape #6711 - Expected behaviour on phones
  4. IOS/Android - Black screen is displayed when try to create room #6712 is failing Add the NewRoomPage #6314

Thanks!

@isagoico
Copy link

We found this issue on Android as well when closing the regression run - #6725. Looks like a Deploy Blocker

@ogumen
Copy link

ogumen commented Dec 13, 2021

I am demoting the Workspace settings - app orientation issue from deploy blockers. It is a new and expected behaviour. Please, @mvtglobally could you update the testing so that we test the orientation change is possible on tablets, but we cannot change to landscape on mobile? Thank you!

Also I am removing the Chat - Messages that are bigger than 10240 characters from the deploy blocker list, it is a duplicate of an existent issue, which apparently was not solved as expected and I have informed the author of the PR. As it is already bug on production for a while it should not block the deploy.

@mountiny from the accessibility perspective restricting the content view and operation to a single display orientation fails WCAG 2.1 SC 1.3.4

@mvtglobally
Copy link

@mountiny @roryabraham We got a new version. What blockers are we good to re-test now?

@isagoico
Copy link

Created this issue to get @mvtglobally added to the @Expensify/applauseleads team so she can get notified too. https://github.com/Expensify/Expensify/issues/188471

@mountiny
Copy link
Contributor

@mvtglobally Great! Could you please retest these three issues:

Thank you very much!

@isagoico
Copy link

While retesting #6724 we found this issue #6740. Fix is being worked on by @luacmartins here #6741 🎉

@isagoico
Copy link

Cherry pick #6741 was tested, we found 2 extra new issues surrounding the New Room creation flow. Not sure if they should be treated as DBs or not @TomatoToaster can you give them a look:

@roryabraham
Copy link
Contributor

@isagoico what's the story with #6665 ?

@isagoico
Copy link

it's the same story that has happened before, I keep missing checking 1 PR off since the new checklist format was introduced 🤦 #6665 was a pass on our side.

@TomatoToaster
Copy link
Contributor

Both of those don't need to be deploy blockers since the feature is still behind beta and a WIP as we build the rest of it. One is a duplicate and I'll keep an eye on the other one since it is a new bug, thanks for the ping @isagoico!

@mvtglobally
Copy link

@TomatoToaster @roryabraham since #6314 is going to Prod as BETA, are we ok to checkoff it them and close this checklist?

@MelvinBot MelvinBot added the Monthly KSv2 label Dec 14, 2021
@TomatoToaster
Copy link
Contributor

TomatoToaster commented Dec 14, 2021 •
edited
Loading

Yes I think it's ok to check off (I just did), I had verified the steps work mostly as expected from the tests/WebQA: #6314 (comment)

The broken behavior is captured in other issues assigned to me 👍🏾

@mvtglobally
Copy link

@roryabraham , trying to close this checklist

Are we ok to check off #6757 based on the comment #6757 (comment) and check off & #6758 > #6758 (comment)

@Julesssss
Copy link
Contributor

Hi @mvtglobally, yeah please go ahead and check off those issues.

@mvtglobally
Copy link

Done

@parasharrajat
Copy link
Member

This seems ready to go to PROD cc: @roryabraham

@roryabraham
Copy link
Contributor

Okay, @Julesssss is the deployer this week, but since he's offline for the night and this is ready to go we can shipit

@roryabraham
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests