Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote concierge / phone support in NewDot workspace v1 #6719

Closed
kevinksullivan opened this issue Dec 11, 2021 · 19 comments
Closed

Promote concierge / phone support in NewDot workspace v1 #6719

kevinksullivan opened this issue Dec 11, 2021 · 19 comments
Assignees
Labels
Design Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@kevinksullivan
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Create workspace
  2. Navigate to any tab in the workspace menu

Expected Result:

Following up on https://github.com/Expensify/Expensify/issues/184190. Let's promote support options for call/chat in each tab of the workspace editor. We will do this by:

  1. Adding the ? icon to the top-right corner of each page within the workspace
    image

  2. When the icon is tapped, go one level of navigation deeper that promotes two options:
    image

  • Chat with concierge - closes out the modal and redirects a user to their DM with concierge
  • Request a setup call - opens the call info modal, using the same design/copy we use in OldDot (see your DM with concierge and tap the phone icon for reference, but let's use the more detailed version from OldDot). Additionally, let's update the existing call modal accessed from the phone icon within the DM with concierge to match this design.

image

Actual Result:

there are no support options promoted within the workspace

Reproducible in staging?: Yes
Reproducible in production?: Yes
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/184190

View all open jobs on GitHub

@kevinksullivan kevinksullivan added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Dec 11, 2021
@MelvinBot
Copy link

Triggered auto assignment to @tjferriss (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot added Overdue and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member labels Dec 11, 2021
@MelvinBot
Copy link

@tjferriss Whoops! This issue is 2 days overdue. Let's get this updated quick!

@tjferriss
Copy link
Contributor

This looks really great. My only comment would be that the grey "?" icon doesn't stand out. Have we considered giving it some color, maybe green.

Alternatively, could we do something to bring attention to it the first time someone opens the workspace editor? Maybe Concierge sends a message about it.

@MelvinBot MelvinBot removed the Overdue label Dec 15, 2021
@kevinksullivan
Copy link
Contributor Author

hm yeah, My thought was that we don't want to call this out to be more prominent than the surrounding product, since it's really a fallback. Green feels a bit "positive", since it is the color we use for all actions we want the user to take in product. Then red felt a bit intense on the other side of that.

@tjferriss
Copy link
Contributor

Those are all good points. I've gotten some feedback on calls where people express they wish they had realized what the "Call" button on OldDot was a long time ago. This is probably where this feedback is coming from. I like your reasoning about this being a fall back and I like that we're going with a universal "?" button. Let's do it!

@MelvinBot
Copy link

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@MelvinBot
Copy link

Whoops! This issue is 2 days overdue. Let's get this updated quick!

@puneetlath puneetlath self-assigned this Dec 25, 2021
@puneetlath
Copy link
Contributor

Would we also want this on the main Workspace page?
image

@MelvinBot MelvinBot removed the Overdue label Dec 25, 2021
@puneetlath
Copy link
Contributor

Also, can we get an svg of the question mark icon? Looks like we don't have that icon in new dot yet.

@puneetlath puneetlath added Internal Requires API changes or must be handled by Expensify staff Weekly KSv2 Design and removed Daily KSv2 labels Dec 26, 2021
@MelvinBot
Copy link

Auto-assign attempt failed, all eligible assignees are OOO.

@puneetlath
Copy link
Contributor

I tried adding the design label, but it looks like everyone is ooo. @Expensify/design can someone give me the svg for the question mark icon whenever you get a chance? Thanks!

@puneetlath
Copy link
Contributor

Asked some questions about the task IDs here: https://expensify.slack.com/archives/C07F03W66/p1640902561149500

@shawnborton
Copy link
Contributor

Icon is here: question-mark-circle.svg.zip

@puneetlath
Copy link
Contributor

Created an issue for battle cards here: https://github.com/Expensify/Expensify/issues/190312

@puneetlath
Copy link
Contributor

@kevinksullivan to confirm, you want the request call page to have the exact same functionality on new dot that it does on old dot? From what I can see, there are a handful of things the old dot page that the new dot page doesn't:

  • the optional "extension" field
  • dynamic messaging in the gray text based on:
  • if it's a weekend:

We have limited availability on the weekends. We'll give you a call back as soon as we can.

  • if it's not a weekend, then it tells you the current wait time

To confirm, you want to update the modal to have all that? It's all doable, we just will need to add the API call to get the wait time.

@puneetlath puneetlath mentioned this issue Jan 2, 2022
5 tasks
@kevinksullivan
Copy link
Contributor Author

@puneetlath yes I think we should add these to NewDot. The callback time was recently added to OldDot, but it would be great to make that consistent in NewDot as well. We could always spin up a separate GH for that as well @puneetlath ?

@puneetlath
Copy link
Contributor

Cool. GH for updating request a call modal is here: #7067

@puneetlath puneetlath added the Reviewing Has a PR in review label Jan 7, 2022
@botify botify closed this as completed Jan 11, 2022
@kevinksullivan
Copy link
Contributor Author

Looks like botify is jumping the gun here.

@puneetlath
Copy link
Contributor

This just hit production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants