[HOLD for payment 2021-12-28] Payment - Keyboard type is wrong for CVV at debit card page - Reported by: @thesahindia

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to Profile > Settings
2. Select Payments
3. Click Add payment method
4. Select Debit card
5. Click on CVV CTA

Expected Result:

Numeric keyboard should open

Actual Result:

Letters keyboard opens

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS
• Android
• Mobile Web

Version Number: 1.1.20-1
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1639348013154400

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @puneetlath (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[MariaHCD]

I'll let @puneetlath do the initial triage here!

[puneetlath]

Confirmed this is indeed an issue. Over to you @MariaHCD!

[mananjadhav]

This is a small fix:

Proposed solution: is to add keyboardType to the text input in AddDebitCardPage

<ExpensiTextInput
      label={this.props.translate('addDebitCardPage.cvv')}
      onChangeText={securityCode => this.clearErrorAndSetValue('securityCode', securityCode)}
      value={this.state.securityCode}
      errorText={this.getErrorText('securityCode')}
      keyboardType={CONST.KEYBOARD_TYPE.NUMBER_PAD} // Add this line
  />

[MelvinBot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[michaelhaxhiu]

Upwork job post - https://www.upwork.com/jobs/~016c765e8ac277bc66

@thesahindia can you apply for the job so we can hire you for the reporting bonus?

First solution proposal for review will be @mananjadhav

[MelvinBot]

Triggered auto assignment to @parasharrajat (Exported)

[MelvinBot]

Triggered auto assignment to @Julesssss (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MelvinBot]

📣 @mananjadhav You have been assigned to this job by @Julesssss!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[parasharrajat]

All good here.
🎀 👀 🎀

[michaelhaxhiu]

@thesahindia is hired for reporting bonus ✅, but still waiting for @mananjadhav to to apply for the job in Upwork.

[michaelhaxhiu]

I'm re-applying the External label on this GH to trigger auto-assignment to a fellow CM, as I'm going OOO for the next 2 weeks. 🙏

[MelvinBot]

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[mananjadhav]

but still waiting for @mananjadhav to apply for the job in Upwork

@michaelhaxhiu @bfitzexpensify Applied and also PR submitted.

[Julesssss]

Merged, awaiting deployment.

[mananjadhav]

@michaelhaxhiu @bfitzexpensify Applied and also PR submitted.

@bfitzexpensify Upwork hires pending.

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.22-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Added keyboardType to cvv #6810

If no regressions arise, payment will be issued on 2021-12-28. 🎊

[laurenreidexpensify]

@mananjadhav @thesahindia I've issued payment 👍🏽 Thanks