Password setup - Message is different when redirected to the magic link page after entering invalid validation code

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue was found when executing #5150

Action Performed:

1. Go to the login page and enter the email/phone
2. Select Forgot option
3. Update the code to any invalid code in the received magic link.
4. Enter the password

Expected Result:

It should redirect to the magic link page with the updated message

Actual Result:

Message is different: "It looks like there was an error with your validation link or it has expired."

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• Mobile Web

Version Number: v1.1.25-0

Reproducible in staging?: Yes

Reproducible in production?: No (New feature)

Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5395235_password.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub
Issue was found when executing #5150

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[francoisl]

I think this is fine – the error message was updated in the Pull Request in this commit after the PR was submitted, but the QA steps were not updated to use the updated message.

The message you got matches what was merged in the PR (https://github.com/Expensify/App/pull/5150/files#diff-22037c1e4dbdea8803b450b3fce06e6c475762a31ecf84b34dc264ba0e443637R431).

cc @akshayasalvi

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.