FEATURE REQUEST: Add Google/Apple sign in on New Dot, like we have on Old Dot

[mvtglobally]

Design doc: https://docs.google.com/document/d/1W0hCQbcvcFIH1mlbSElovXKNaP_FK9J3MU3ESzH-y34/edit#

Pre-design: https://expensify.slack.com/archives/C01GTK53T8Q/p1678126175371849

Technical pre-design: https://expensify.slack.com/archives/C01GTK53T8Q/p1680016894091629

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Try to login with Google/Apple sign in

Expected Result:

User should be able to login with Google/Apple sign in

Actual Result:

User can only login with email

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.26-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1641509570059600

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @alexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[MelvinBot]

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcochavezf]

This issue should be internal because it will require checking the implementation of Google/Apple of OldDot to make it compatible with the corresponding Web-E commands.

[MelvinBot]

Triggered auto assignment to @puneetlath (Internal) because issue was reported by a contributor who needs to be compensated if this issue is fixed

[marcochavezf]

Update: I did a bit of research of the most maintained third-party libraries for both Google and Apple sign-in functionality and those are:

• https://github.com/react-native-google-signin/google-signin
• https://github.com/invertase/react-native-apple-authentication

Also asked in #expensify-open-source for a second opinion and we're ok using those libraries.

[puneetlath]

Would we also use libraries for web/desktop? Or just do it ourselves?

[marcochavezf]

Would we also use libraries for web/desktop? Or just do it ourselves?

Ah that's a good question, I don't know yet, also I'm not sure if we can re-use the native libraries on web/desktop. I will investigate and compare.

[marcochavezf]

Related to using libraries for web/desktop, TL:DR; I found out for Google SignIn is better to implement it ourselves.

I checked out the implementation of https://github.com/anthonyjgrove/react-google-login (which is the most popular library for Google SignIn in regular React) and I found out the implementation is relatively simple and it's better to implement it ourselves because the library contains features that we don't need (like a specific Google button, offline access, Google SignOut) and we should adapt our code to the library (create a new component to wrap the library) when we can create a function and simply hook it up to a regular Button component.

[marcochavezf]

When I'm testing the Google Sign-in I'm having the error Error 403: restricted_client on iOS because the OAuth consent screen is not set up in Google Cloud Platform:

Rory (ring3) was trying to help with that but he also doesn't have permission. I'm going to need someone of ring0 to set it up in GCP.

[rafecolton]

Did my best to configure the consent screen but not sure if it's correct, and it says it may need 4-6 weeks for Google to verify before we can publish it. More info in the linked internal issue.

[marcochavezf]

Update:

• The Google SignIn has been implemented for iOS and Android and it's working fine locally.
• I implemented the Google SignIn on Desktop using the google-auth-library-nodejs library. I tried using first the same approach used on web, but I was having issues with Electron (https://expensify.slack.com/archives/C01GTK53T8Q/p1644432240338919). Also, I found out the web library hasn't been officially supported for Electron (link 1 and link 2) and there have been situations where all Electron apps using the web library suddenly had issues and needed to wait for an update or change the BrowserWindow.webPreferences.nativeWindowOpen configuration in Electron.

[marcochavezf]

No update this week, I've been focused on an N7 issue also I'm going to be OOO for a few days. I will come back to it next week.

[marcochavezf]

No update

[shawnborton]

What's the latest here?

[marcochavezf]

The 2 pending issues and the email wrap-up. I will move this to weekly, since I'm a little swamped with other higher priorities atm

[marcochavezf]

No update

[JmillsExpensify]

Any update?

[JmillsExpensify]

Still not sure where we're at.

[JmillsExpensify]

Same

[marcochavezf]

No update, focused on wave issues. The 2 remaining issues are minor and I think low priority, should be part of a VIP project? So I can give priority to them

[marcochavezf]

No update

[JmillsExpensify]

@marcochavezf What's the latest on this one?

[marcochavezf]

No update here since I've been prioritizing wave7 issues. I think the two remaining issues can be part of #vip-vbs

[quinthar]

Don't we already have this?

[shawnborton]

Friendly bump - what's the latest on this one @marcochavezf ?

[marcochavezf]

Just the wrap-up email is pending but I've been deprioritizing because of wave bugs. I will prioritize it this week for real, sorry for the delay here.

[marcochavezf]

Writing the wrap-up email, aiming to send it out later today

[marcochavezf]

Email sent, closing it out