Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Chat - No preview when attaching large pdf file #7365

Closed
kavimuru opened this issue Jan 22, 2022 · 11 comments
Closed

iOS - Chat - No preview when attaching large pdf file #7365

kavimuru opened this issue Jan 22, 2022 · 11 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Jan 22, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open app and login
  2. Tap on any chat
  3. Tap on + sign > Add Attachment > Choose document
  4. Choose the attached file in the issue (a large pdf file)

Expected Result:

Verify a preview of the PDF is displayed before uploading to the conversation

Actual Result:

The preview of the pdf file is not showing

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS

Version Number: 1.1.32-0
Reproducible in staging?: yes
**Reproducible in production?:**cyes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
[OMCre
Bug5417158_IMG_5829

Bug5417158_Issue_pdf.mp4

ate Battery User Manual (1).pdf](https://github.com/Expensify/App/files/7917369/OMCreate.Battery.User.Manual.1.pdf)

Upwork job URL: https://www.upwork.com/jobs/~011ea8673c607beed8
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@johnmlee101
Copy link
Contributor

This has to deal with our PDF view most likely here:

so that would be a great starting place to fix this. Should be fine marking as External

@johnmlee101 johnmlee101 added the External Added to denote the issue can be worked on by a contributor label Jan 25, 2022
@johnmlee101 johnmlee101 removed their assignment Jan 25, 2022
@MelvinBot
Copy link

Triggered auto assignment to @SofiedeVreese (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@SofiedeVreese
Copy link
Contributor

I'm going to have to reassign this one, I'm sorry. I'm back from OOO and autoassigner is playing catch-up so I'm absolutely smashed with assigned GHs atm.

@SofiedeVreese SofiedeVreese removed the External Added to denote the issue can be worked on by a contributor label Jan 25, 2022
@SofiedeVreese SofiedeVreese removed their assignment Jan 25, 2022
@SofiedeVreese SofiedeVreese added the External Added to denote the issue can be worked on by a contributor label Jan 25, 2022
@MelvinBot
Copy link

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@trjExpensify
Copy link
Contributor

👋 Job on upwork is here: https://www.upwork.com/jobs/~011ea8673c607beed8
@kavimuru, just to confirm.. this issue was reported by Applause, right? That detail is missing from the OP.

@botify botify removed the Daily KSv2 label Jan 26, 2022
@MelvinBot MelvinBot added the Weekly KSv2 label Jan 26, 2022
@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

@MelvinBot MelvinBot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 26, 2022
@MelvinBot
Copy link

Triggered auto assignment to @pecanoro (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mvtglobally
Copy link

@trjExpensify updated reporter to Applause

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@pecanoro
Copy link
Contributor

pecanoro commented Feb 3, 2022

@johnmlee101 tried to test this on iOS (I don't have an iPhone) and he couldn't reproduce it either, so I am going to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants