Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payments - Options "instant debit card" and "1-3 business days" aren't displayed when clicking "Transfer Balance" #7398

Closed
kavimuru opened this issue Jan 25, 2022 · 8 comments
Assignees

Comments

@kavimuru
Copy link

kavimuru commented Jan 25, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing #7200

Action Performed:

Pre: Login with expensify account which already has payments

  1. Open Payments page.
  2. Click Transfer Balance Link.

Expected Result:

Confirm that the transfer button is disabled if the following conditions are true.
i. Transfer Amount is less than $ 0.30.
ii. Which Account is not selected.

Actual Result:

Don't see the options instant debit card and 1-3 business days. Dropdown menu with Bank account/ Debit card is opened.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: v1.1.32-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5423005_Transfer

Bug5423005_transfer.mp4

Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@aldo-expensify
Copy link
Contributor

I'm able to replicate this:

  • I added an Open VBA account using the SO.
  • Click on Transfer Balance opens a dropdown

@parasharrajat is this expected behaviour?

@MelvinBot MelvinBot removed the Overdue label Jan 31, 2022
@parasharrajat
Copy link
Member

parasharrajat commented Jan 31, 2022

KYCWall was added by Marc over the TransferBalance link so that users first add/complete the VBA flow before transferring the balance.

I don't know the expected behavior of KYCWall. Better to ask Marc about this.

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Feb 2, 2022

so.. debugging and looking at the code, it seems like the popover to add payment methods appear if you don't have a debit card and don't have a default bank account (this check). Here @kavimuru only has paypal, so it looks like intended behaviour.

Also, to continue you will need to have a wallet in Gold tier, otherwise you will be ask to verify your identity (check here). I'm not sure about how you get a gold tier wallet in staging... doing Onfido validation?

If you meet these conditions, you will see the page:

The problem now is that I cannot change the big number, my guess is that I cannot change it because I don't have any balance in my wallet. How do you put something in your wallet? @parasharrajat

@parasharrajat
Copy link
Member

You can change this this.props.userWallet.currentbalance to 10000 for $100.

@aldo-expensify
Copy link
Contributor

I think the steps in the PR are a bit off, it says that the button will be disabled when balance is below 0.30, but that is not the case:

https://user-images.githubusercontent.com/87341702/152179080-4d9fcbfa-da5e-4770-ae13-46a843a19da7.png

The button is disabled when the balance is below the fee:

Screen Shot 2022-02-02 at 10 00 55 AM

Clicking the green "Transfer" button with a balance modified in the frontend gives you a growl, which is reasonable:

Screen Shot 2022-02-02 at 10 06 23 AM

I didn't get to see

All the rest of the things regarding the views to add debit/bank account, selecting them, button disabling on fee > balance, button disabled on which account not being selected seem to be working fine

@aldo-expensify
Copy link
Contributor

I'll close this as the QA just failed because @kavimuru was missing debit/bank account and possibly a gold wallet.

@parasharrajat
Copy link
Member

The button is disabled when the balance is below the fee:

yeah, this is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants