IOU - All the cancelled request preview shows loading spinner for reopened accounts - reported by @Tushu17

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Precondition: Closed an account then reopen again

1. Launch the app
2. Login with reopened account credentials
3. Open Direct message with account who I canceled request money.

Expected Result:

All canceled request money should appear without any issues

Actual Result:

All canceled request money shows spinner.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.33-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5423926_Canceled_2601.mp4

Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MitchExpensify]

Upwork Job

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[MelvinBot]

Current assignee @stitesExpensify is eligible for the Exported assigner, not assigning anyone new.

[railway17]

Could you attach reproduce video again?
I can't replicate on my side. I tested the latest main branch.

[rushatgabhane]

@railway17 are you able to replicate this on production?

[railway17]

@rushatgabhane
I didn't test in production.
But is it possible to test in product with my personal account?

I've contributed to 1 issue in Expensify, but not sure I can test in prod or not....
In the issue replication, I am not clear what reopened account is.

Just tried the below steps:
login, request, cancel, logout, re-login, open direct chat.
But can't replicate.
My replication flow is correct?

[rushatgabhane]

@railway17 Thanks for the details! For reopening the account, you first need to close it.

To close: settings -> security -> close account.
To reopen: just sign in to the same account

[railway17]

20220129120409526.mp4

@rushatgabhane
I can't see any option to close the account.

[rushatgabhane]

@railway17 can you try it in production (new.expensify.com) I'm not sure why you can't see close account page as it isn't hidden in any beta.

[railway17]

@rushatgabhane
Ok, I can see and replicate it in production.
Looks like latest main is not same with current prod.
I can't see Close Account in en.js
Let me try to find which commit is current prod

[rushatgabhane]

@railway17 main has close account feature. you might need to sync your fork if you're testing on it 😄

[railway17]

@rushatgabhane
I have another question.
Let's assume that this issue is fixed and there was $500 requested money before closing the account.
When login reopened account, this amount should be kept?

The current action result is that old money is reset to 0 when login and requesting another money.
But Expected result doesn't mention about keeping old total requested money

[stitesExpensify]

FYI @railway17 @rushatgabhane is OOO at the moment, i'm sure he'll respond when he's back

[rushatgabhane]

@railway17 woah, sorry for being so late to respond.

Let's assume that this issue is fixed and there was $500 requested money before closing the account.
When login reopened account, this amount should be kept?

No, the amount shouldn't be kept because all expense data is deleted by expensify (as per the email received on deletion).

[rushatgabhane]

@stitesExpensify I think this is an issue that should be fixed on the backend.

[marcaaron]

I'm also confused about the bug...

Precondition: Closed an account then reopen again
Launch the app
Login with reopened account credentials
Open Direct message with account who I canceled request money.

Are we canceling the money request and then closing the account or closing an account that has active requests?

[stitesExpensify]

Cancel and then close the account, although I would guess that other cases also exist

[marcaaron]

Here's what I am seeing so far...

The IOUPreview component tries to fetch the report in the URL or from the action but the API returns 666 "no longer exists". The other participant has no issues viewing the UI (assuming they retain access to the report, but the other user who closed their account does not).

Maybe dumb question... but can we just reshare these IOU reports when someone reopens their account?

Thinking we can just find all IOU reports where they are the accountID or managerID and re-share them. Then they will have access to the retracted report? Retracting the report seems fine is the lack of access to it that messes up the UI.

[marcaaron]

Maybe I'm not getting how this feature works. I can't ever remember.

[marcaaron]

Oh actually it would just be if they are the managerID I think. Since if the report has your accountID then you would be able to access it still 🤔

[marcaaron]

cc @Julesssss @mountiny as I think you guys are probably pretty familiar with the IOU flows and can please tell me if you see any obvious issues with this approach?

Problem:

• We unshare IOU reports when a "manager/debtor/payer" closes their account.
• If they reopen their account the UI breaks since they are trying to access reports they can no longer access.

Solution:

• Reshare the IOU reports if the managerID account is reopened

[marcaaron]

actually, that solution appears to break all new IOU transactions. 😕

[marcaaron]

Just noting that if you do not cancel the request but close and reopen you will still get a loading spinner as the payer though the requester will see that they are owed:

Creating a new request as the user who did not close their account works

But will lead to them seeing two report actions

What's also weird is that the previous action "Details" says that the other user paid (but they didn't)

And the new preview for the new transaction looks OK

This feature seems very broken when an account gets closed - did we just not think about what would happen at all? This might be too big of an issue for me to focus on at the moment, but will wait for input from others in case I am wrong and there's an obvious solution.

[puneetlath]

If we canceled the IOU request before unsharing the report, would that solve it?

[marcaaron]

ah sorry, can you clarify what you think that would solve? I'm not sure what the "it" in your question refers to.

[puneetlath]

Sorry, what I meant was that if we cancel the IOU request before closing the account, then theoretically there is nothing that needs to be reshared when the account is re-opened since the IOU no longer exists. Perhaps that is overly simplified though.

[marcaaron]

Got it, the loading spinners will still happen even if you manually cancel the request before closing your account. We could cancel the IOU transaction automatically when someone closes their account - but they would still lose access to the IOU report itself (so the UI will keep showing the loading spinner in both scenarios).

I still can't really think of why someone would need to have an IOU report unshared from them when they close their account.

[marcaaron]

Looks like when someone closes their account the "active" IOU report's state and status go from:

state = 1
status = 1

to

state = 0
status = 0

AFAICT iou reports should not ever have a state of 0 and are always either SUBMITTED or MANUALREIMBURSED.

It is getting rejected like @stitesExpensify found above.

Ok so, alternative idea...

1. If the IOUReport shared has a non-zero total then rejact all the transactions on behalf of the user.
2. Do not "reject" the report or change the state or status of the IOU report (that should now have a zero total).
3. Re-share the IOU report with the user when they reopen their account (so we don't have to create a new one)

[marcaaron]

Tested the above solution out and it works pretty good here are some drafts:

https://github.com/Expensify/Web-Expensify/pull/35453
https://github.com/Expensify/Auth/pull/7228

[puneetlath]

Nice!

[marcaaron]

Still working on this, but it's not a daily priority for me since closing accounts is an edge case.

[JmillsExpensify]

+1. I think weekly is appropriate.

[marcaaron]

Related Auth PR has been merged. Wrote some integration tests for the Web-E PR (still on HOLD waiting for Auth deploy).

[JmillsExpensify]

Not sure why I'm subscribed to this issue haha, but just noticed we need to create an Upwork job for the reporting bonus.

[puneetlath]

@Tushu17 can you please apply here for the reporting bonus: https://www.upwork.com/jobs/~0102f107207d43a2df

[Tushu17]

@puneetlath Ok applied, Thanks.

[puneetlath]

Great, paid!

[puneetlath]

Looks like we're done here!