Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - The #announce and #admin rooms appears in LHN by default when a new workspace is created #7429

Closed
kavimuru opened this issue Jan 27, 2022 · 5 comments
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Precondition: Create a new expensifail account

  1. Launch the app
  2. Log in with new expensifail account
  3. Tap on Plus button and tap Create a Workspace
  4. On Workspace Tap on General Setting
  5. Change the name and currency for Workspace
  6. Tap Save button
  7. Go back to LHN

Expected Result:

No default rooms get created

Actual Result:

The #announce and #admins rooms appears in LHN after created Workspace

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.33.2
Reproducible in staging?: Yes
Reproducible in production?: No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5424820_Screenshot_20220126-164931_New_Expensify

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Jan 27, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@K4tsuki
Copy link
Contributor

K4tsuki commented Jan 27, 2022

Related to this issue #5946

Shouldn't #announce room be available in LHN after user create new workspace?

@flodnv
Copy link
Contributor

flodnv commented Jan 27, 2022

I agree @K4tsuki: Given #5946 is closed, it looks to me like we now implemented the desired behavior. @neil-marcellini @yuwenmemon what do you say?

@flodnv flodnv removed their assignment Jan 27, 2022
@yuwenmemon
Copy link
Contributor

Correct 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants