Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on X to exit room details takes user to LHN - reported by @sobitneupane #8129

Closed
mvtglobally opened this issue Mar 14, 2022 · 23 comments
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@mvtglobally
Copy link

mvtglobally commented Mar 14, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open up a shared room on newdot
  2. Click on the room name to view the room Details
  3. Click on X button to exit the Details page

Expected Result:

User is returned to room

Actual Result:

User is returned to LHN/list of chats

Workaround:

unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android
  • Mobile Web

Version Number: 1.1.42-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-03-04.at.14.11.56.mov

Expensify/Expensify Issue URL:
Issue reported by: @sobitneupane
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1646382546987179

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Mar 14, 2022
@MelvinBot
Copy link

Triggered auto assignment to @stephanieelliott (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Mar 14, 2022
@sobitneupane
Copy link
Contributor

Will post solution as the reporter of this issue if considered external.

@stephanieelliott stephanieelliott changed the title Clicking on Cross Button (x) in room details page takes user to LHN - reported by @sobitneupane Clicking on X to exit room details takes user to LHN - reported by @sobitneupane Mar 15, 2022
@stephanieelliott
Copy link
Contributor

Was able to reproduce, I think this weird behavior and solving would be valuable. Passing on to Engineering for further review!

@MelvinBot
Copy link

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@joelbettner
Copy link
Contributor

Looks like it has what it needs to be worked on. I don't have the bandwidth to take it on.

@joelbettner joelbettner removed their assignment Mar 15, 2022
@stephanieelliott
Copy link
Contributor

@joelbettner does this need to be worked on internally, or can this be assigned to an external contributor?

@MelvinBot
Copy link

Eep! 4 days overdue now. Issues have feelings too...

@MelvinBot
Copy link

Still overdue 6 days?! Let's take care of this!

@luacmartins luacmartins self-assigned this Mar 24, 2022
@luacmartins
Copy link
Contributor

I'll pick this up!

@MelvinBot MelvinBot removed the Overdue label Mar 24, 2022
@luacmartins luacmartins added the Improvement Item broken or needs improvement. label Mar 24, 2022
@luacmartins
Copy link
Contributor

PR is mostly done. I'll put this on review shortly.

@MelvinBot MelvinBot removed the Overdue label Mar 28, 2022
@luacmartins luacmartins added the Reviewing Has a PR in review label Mar 28, 2022
@MelvinBot
Copy link

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@luacmartins
Copy link
Contributor

luacmartins commented Apr 4, 2022

Hmm PR has been deployed to staging 5 days ago. Not sure why this overdue comment was posted without a label.

@melvin-bot
Copy link

melvin-bot bot commented Apr 12, 2022

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@luacmartins
Copy link
Contributor

PR deployed to prod 7 days ago. Closing.

@sobitneupane
Copy link
Contributor

Hello @luacmartins, I am the reporter of the issue. I am not paid for reporting this issue.

@luacmartins luacmartins reopened this Apr 13, 2022
@luacmartins
Copy link
Contributor

Sorry @sobitneupane, I missed that. Adding External label to pay @sobitneupane as issue reporter.

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Apr 13, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 13, 2022

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@luacmartins
Copy link
Contributor

luacmartins commented Apr 13, 2022

@dylanexpensify could you please pay the reporting bonus to @sobitneupane? We fixed this one internally, so you can close the issue once it's been paid. Thank you so much!

@dylanexpensify
Copy link
Contributor

Yes of course! @sobitneupane please apply here!

@sobitneupane
Copy link
Contributor

Yes of course! @sobitneupane please apply here!

Applied.

@dylanexpensify
Copy link
Contributor

@sobitneupane offer sent!

@sobitneupane
Copy link
Contributor

@sobitneupane offer sent!

Accepted

@dylanexpensify
Copy link
Contributor

Nice! Payment sent, contract ended, posting removed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants