Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD] "okay, got it." Modal has some extra empty space on top - reported by @Tushu17 #8457

Closed
mvtglobally opened this issue Apr 4, 2022 · 5 comments
Closed

[HOLD] "okay, got it." Modal has some extra empty space on top - reported by @Tushu17 #8457

mvtglobally opened this issue Apr 4, 2022 · 5 comments
Labels
Improvement Item broken or needs improvement. Monthly KSv2

Comments

@mvtglobally
Copy link

mvtglobally commented Apr 4, 2022 •
edited
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. You need to have a workspace and some members in it
  2. Go to close account page
  3. Type default contact method
  4. Press close account button
  5. View the "ok, got it" modal.

Expected Result:

There should be same space across borders

Actual Result:

Modal has too much extra empty space on top

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screenshot_20220324-032238_New Expensify

Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1648072472591519

View all open jobs on GitHub
@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Apr 4, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 4, 2022

Triggered auto assignment to @isabelastisser (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Apr 4, 2022
@mvtglobally mvtglobally changed the title "okay, got it." Modal has some extra empty space on top "okay, got it." Modal has some extra empty space on top - reported by @Tushu17 Apr 4, 2022
@mallenexpensify mallenexpensify changed the title "okay, got it." Modal has some extra empty space on top - reported by @Tushu17 [HOLD] "okay, got it." Modal has some extra empty space on top - reported by @Tushu17 Apr 4, 2022
@mallenexpensify
Copy link
Contributor

Hold plz, this might be a dupe (which was reported first) for #8404

@mallenexpensify mallenexpensify mentioned this issue Apr 4, 2022
Closed
@isabelastisser isabelastisser added Engineering Improvement Item broken or needs improvement. labels Apr 5, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 5, 2022

Triggered auto assignment to @timszot (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@isabelastisser
Copy link
Contributor

Sorry, I just saw Matt's comment now so I'm removing engineering.

@mallenexpensify
Copy link
Contributor

Gonna close this one, added @Tushu17 as reported by on #8404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Item broken or needs improvement. Monthly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@timszot @mallenexpensify @isabelastisser @mvtglobally