Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App update - Without prompt the build gets updated #8551

Closed
kavimuru opened this issue Apr 8, 2022 · 5 comments
Closed

App update - Without prompt the build gets updated #8551

kavimuru opened this issue Apr 8, 2022 · 5 comments
Assignees

Comments

@kavimuru
Copy link

kavimuru commented Apr 8, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing the PR #8350

Action Performed:

  1. Have App opened and foregrounded before an update is released
  2. Wait for update to be released and then background App - open a new tab
  3. Wait for update to be released and then foreground App

Expected Result:

You should see a prompt to update

Actual Result:

I don't see the prompt but it gets updated.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: v1.1.51-0 to be updated to v1.1.52-0
Reproducible in staging?: Y
Reproducible in production?: New feature
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5521232_start2.mp4

Bug5521232_Screen_Shot_2022-04-05_at_3 20 22_PM

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Apr 8, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Apr 8, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Apr 8, 2022

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@marcaaron
Copy link
Contributor

Hmm I don't really understand these reproduction steps, sorry. How can we test this without having an open tab exist before a release goes out?

Reproducible in production?: New feature

What does this mean? Did we add a new feature?

Not sure what we want to do about this one @roryabraham or if there's a way to test this.

@roryabraham
Copy link
Contributor

I'm not sure what the video is supposed to show, but according to the description, this is the intended behavior. The web app is supposed to refresh and update itself if you background it. It's a feature, not a bug 😄 In fact, it seems that maybe that behavior has just been broken since its inception and was just fixed by #8350.

@roryabraham roryabraham removed the DeployBlockerCash This issue or pull request should block deployment label Apr 8, 2022
@marcaaron
Copy link
Contributor

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants