[HOLD for payment 2022-06-15] [$250] Android - Status bar color is different when a modal/popover is open @Tushu17

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Open App
Click on +
Check the status bar color

Expected Result:

Status bar color should also change

Actual Result:

Status bar color is different when a modal/popover is open

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Android

Version Number: 1.1.55.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @Tushu17

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1646659016455839

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @isabelastisser (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[madmax330]

Hmm I'm not sure the status bar changes, color. I think it's because we add an overlay to the background that doesn't get added to the status bar.

[madmax330]

Looks like we found a simple solution here: https://expensify.slack.com/archives/C01GTK53T8Q/p1651860311358399?thread_ts=1650366153.665479&cid=C01GTK53T8Q

Tagging as external

[melvin-bot]

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Tushu17]

Proposal

(Just c/p here for easy access)
We just have to pass statusBarTranslucent in ReactNativeModal

App/src/components/Modal/BaseModal.js

Line 79 in 54f55b6

<ReactNativeModal

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[melvin-bot]

Triggered auto assignment to @tgolen (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[NicMendonca]

Job posting: https://www.upwork.com/jobs/~01d231a130b36a039a

[tgolen]

Cool, 🟢 to hire @Tushu17 .

[Tushu17]

@NicMendonca okay, Applied on upwork👍

[Tushu17]

I have raised the PR.

[NicMendonca]

Thanks @Tushu17 🙌

[mountiny]

Chiming in as I have been oo and I have an emptier plate and Tim is ooo this week.

[mountiny]

@Tushu17 Thanks for the proposed new solution to get around the regression. When do you estimate you could have new PR up we could test and review? Thank you 🙌

[Tushu17]

I have raised the PR @mountiny

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.71-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix status bar color when a modal is open #9210

If no regressions arise, payment will be issued on 2022-06-13. 🎊

[mountiny]

There was a regression with the original PR so removing the label and title prefix and we will wait for the second PR which was just deployed to staging.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.73-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix status bar color when modal/popover is open #9312

If no regressions arise, payment will be issued on 2022-06-15. 🎊

[NicMendonca]

@rushatgabhane @Tushu17 paid! ty!