[HOLD for payment 2022-10-18] [$250] Unresponsive camera opens on iOS if the camera permission is denied - reported by @adeel0202

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. (Make sure you have denied the camera permission)
2. Go to settings > profile
3. Tap on the avatar icon
4. Select Upload photo
5. Select Take photo
6. Observe that the camera opens and it's unresponsive

Expected Result:

A popup should be shown that asks the user to enable permission (just like it is happening on Android)

Actual Result:

The camera opens and doesn't respond

Workaround:

unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.1.57-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1649244989.MP4

Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1649245469303159

View all open jobs on GitHub

this job

[melvin-bot]

Triggered auto assignment to @conorpendergrast (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[conorpendergrast]

@adeel0202 do you have steps for 1 ("(Make sure you have denied the camera permission)")? I don't see that as an option in Settings > New Dot

[adeel0202]

@conorpendergrast, you can go to settings of your iPhone, select New Expensify app and disable the Camera permissions. Or, you can uninstall the app, install again, try to access the camera and when you will be asked to allow the camera permissions, just deny it.

[Julesssss]

I'm going to take this, I can reproduce it on iOS and I agree with the expected result.

[Julesssss]

Not overdue

[Julesssss]

Reverting to external as I won't be able to work on this for a while

[melvin-bot]

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[jboniface]

this job

[Julesssss]

We prefer to not use platform conditionals, so it sounds like we'll need two files then :/

[mananjadhav]

@aimane-chnaif Your proposal looks good to me. I am only concerned about the need for updating the Podfile, but it seems it loads the pop of settings the next time? If that's not the case any specific reason why we need to add it now? Nevertheless your code seems to work, so I am find to handle that in the PR.

🎀 👀 🎀 
C+ reviewed

[aimane-chnaif]

I am only concerned about the need for updating the Podfile

request(PERMISSIONS.IOS.CAMERA)
        .then((permission)

If not added, permission in request callback always returns UNAVAILABLE when camera permission is not granted yet, even without showing user alert to grant/deny permission.
Previous assignee didn't know about this pod update and that's why they commented like this:

And the library readme clearly stated that permission to check or request should be added in podfile:

[melvin-bot]

📣 @aimane-chnaif You have been assigned to this job by @Julesssss!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@mananjadhav, @Julesssss, @arielgreen, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Julesssss]

I recently upgraded XCode and I'm having some serious problems with my XCode env and phsical device. I will get to this soon! 😫

[arielgreen]

@aimane-chnaif sent an offer in Upwork

[arielgreen]

@Julesssss is this waiting on something from you?

[aimane-chnaif]

@Julesssss is this waiting on something from you?

@arielgreen No. PR was merged this Monday. This week there were no staging/production deployments yet. So just waiting for it.

[Julesssss]

Yeah, thanks @aimane-chnaif.

Also, the App deploy has been blocked so the automated 7 days... message wasn't posted to this issue yet. It should occur today hopefully 🤞

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.12-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix "Unresponsive camera opens on iOS if the camera permission is denied" #11231

If no regressions arise, payment will be issued on 2022-10-18. 🎊

[arielgreen]

Paid.

[mananjadhav]

@arielgreen The C+ payment is pending for this one.

[arielgreen]

@mananjadhav sorry about that -- just sent over.

[mananjadhav]

No worries. Thanks @arielgreen