Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Only one Payload formdata with name:expensify_freePlanBankAccountID toggling offline/online in workspace settings #9042

Closed
kavimuru opened this issue May 16, 2022 · 11 comments
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Monthly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing #8946

Action Performed:

  1. Launch the NewDot login
  2. Click on your profile pic and then click on your Workspace
  3. Click on General Settings
  4. Open the developer console (F12 on chrome) and go to the Network Tab
  5. In the Network tab, turn off the internet connection and then turn it back on
  6. Still in the Network Tab, Check the api?command=Get request for payload formData containing name:

Expected Result:

There are two api?command=Get request with the payload formData containing name: expensify_freePlanBankAccountID

Actual Result:

There is only one api?command=Get request with the payload formData containing name: expensify_freePlanBankAccountID

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.1.61-3
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5573792_Recording__326.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented May 16, 2022

Triggered auto assignment to @ctkochan22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@ctkochan22 ctkochan22 added Improvement Item broken or needs improvement. Weekly KSv2 and removed Daily KSv2 labels May 17, 2022
@tgolen
Copy link
Contributor

tgolen commented May 17, 2022

@kavimuru Why is it expected that there would be two requests? Can you point me to where that assumption comes from?

@tgolen
Copy link
Contributor

tgolen commented May 17, 2022

Also, I was unable to reproduce this and I only saw one GET request for expensify_freePlanBankAccountID

@mvtglobally
Copy link

@tgolen We found this issue as part of the PR #8946
Steps refer to "make sure there are two api?command=Get requests". Let us know if we misunderstood this step

@melvin-bot melvin-bot bot added the Overdue label May 26, 2022
@ctkochan22
Copy link
Contributor

Busy with n8 and n10 stuff, hopefully able to look into why we need to make two commands this week

@melvin-bot melvin-bot bot removed the Overdue label May 31, 2022
@ctkochan22
Copy link
Contributor

I can't get to this at the moment esp after taking on some N7 refactor stuff. Going to unassign

@ctkochan22 ctkochan22 removed their assignment Jun 8, 2022
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jul 1, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 1, 2022

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Aug 9, 2022
@tgolen
Copy link
Contributor

tgolen commented Aug 17, 2022

@PauloGasparSv Can you please help us understand why this is looking for two requests?

make sure there are two api?command=Get request with the payload formData containing name: expensify_freePlanBankAccountID

I still am only seeing one request, but I think that's the way it should be.

@melvin-bot melvin-bot bot removed the Overdue label Aug 17, 2022
@tgolen tgolen self-assigned this Aug 17, 2022
@PauloGasparSv
Copy link
Contributor

Sure!
@kavimuru @tgolen, I don't think this is an issue.

That was just the amount of times the request appeared to me while testing and developing the feature. And if I removed the network toggle feature one of those request kept being fired.

I think it was being called somewhere else in the code not related to my P.R. and the steps are to make sure my changes were firing a request.

So I think we can close this.

@tgolen
Copy link
Contributor

tgolen commented Aug 17, 2022

Great, thank you! I will do the honors then.

@tgolen tgolen closed this as completed Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Monthly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants