-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web - Only one Payload formdata with name:expensify_freePlanBankAccountID toggling offline/online in workspace settings #9042
Comments
Triggered auto assignment to @ctkochan22 ( |
@kavimuru Why is it expected that there would be two requests? Can you point me to where that assumption comes from? |
Also, I was unable to reproduce this and I only saw one GET request for |
Busy with n8 and n10 stuff, hopefully able to look into why we need to make two commands this week |
I can't get to this at the moment esp after taking on some N7 refactor stuff. Going to unassign |
This issue has not been updated in over 15 days. eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Issue not reproducible during KI retests. (First week) |
@PauloGasparSv Can you please help us understand why this is looking for two requests?
I still am only seeing one request, but I think that's the way it should be. |
Sure! That was just the amount of times the request appeared to me while testing and developing the feature. And if I removed the network toggle feature one of those request kept being fired. I think it was being called somewhere else in the code not related to my P.R. and the steps are to make sure my changes were firing a request. So I think we can close this. |
Great, thank you! I will do the honors then. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue was found when executing #8946
Action Performed:
Expected Result:
There are two api?command=Get request with the payload formData containing name: expensify_freePlanBankAccountID
Actual Result:
There is only one api?command=Get request with the payload formData containing name: expensify_freePlanBankAccountID
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.1.61-3
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5573792_Recording__326.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: