Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Adding/removing Avatar in Profile and Workspace pages is not behaving the same - reported by @Puneet-here #9239

Closed
mvtglobally opened this issue May 31, 2022 · 28 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@mvtglobally
Copy link

mvtglobally commented May 31, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open settings > workspace > general setting
  2. Tap on avatar and upload an image
  3. Check the image will get saved itself
  4. Now go back to settings page and click on profile
  5. Now tap on avatar and upload an image
  6. Check the image won't get saved itself

Expected Result:

The behavior should be consistent

Actual Result:

The behavior isn't consistent

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.69-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://expensify.slack.com/files/U037WGYT199/F03CVP974EA/screen_recording_2022-04-27_at_4.28.55_am.mov

Expensify/Expensify Issue URL:
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1651014262709629

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels May 31, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 31, 2022

Triggered auto assignment to @flaviadefaria (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 31, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 31, 2022

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@flaviadefaria flaviadefaria removed their assignment May 31, 2022
@MonilBhavsar MonilBhavsar added the Improvement Item broken or needs improvement. label Jun 1, 2022
@MonilBhavsar
Copy link
Contributor

Raised a discussion in slack https://expensify.slack.com/archives/C03U7DCU4/p1654081388016319

@MonilBhavsar
Copy link
Contributor

As discussed in the slack, we'll update the workflow considering #8511. I'm going to work on this.

@MonilBhavsar MonilBhavsar added the Internal Requires API changes or must be handled by Expensify staff label Jun 2, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 2, 2022

A Contributor Manager will be assigned to issue payment via Upwork if we deploy an associated Pull Request to production. Per Contributing.md.

@MonilBhavsar MonilBhavsar changed the title Adding/removing Avatar in Profile and Workspace pages is not behaving the same - reported by @Puneet-here [HOLD] Adding/removing Avatar in Profile and Workspace pages is not behaving the same - reported by @Puneet-here Jun 2, 2022
@melvin-bot melvin-bot bot added the Overdue label Jun 6, 2022
@MonilBhavsar MonilBhavsar added Weekly KSv2 and removed Daily KSv2 labels Jun 6, 2022
@melvin-bot melvin-bot bot removed the Overdue label Jun 6, 2022
@MonilBhavsar
Copy link
Contributor

Making it weekly and is on hold

@melvin-bot melvin-bot bot added the Overdue label Jun 14, 2022
@MonilBhavsar
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Jun 15, 2022
@melvin-bot melvin-bot bot added the Overdue label Jun 23, 2022
@MonilBhavsar
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Jun 24, 2022
@melvin-bot melvin-bot bot added the Overdue label Jul 4, 2022
@MonilBhavsar
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Jul 4, 2022
@melvin-bot melvin-bot bot added the Overdue label Jul 12, 2022
@melvin-bot melvin-bot bot removed the Overdue label Sep 9, 2022
@melvin-bot melvin-bot bot added the Overdue label Sep 19, 2022
@MonilBhavsar
Copy link
Contributor

Doing this week

@melvin-bot melvin-bot bot removed the Overdue label Sep 21, 2022
@JmillsExpensify JmillsExpensify changed the title Adding/removing Avatar in Profile and Workspace pages is not behaving the same - reported by @Puneet-here [Bug] Adding/removing Avatar in Profile and Workspace pages is not behaving the same - reported by @Puneet-here Sep 21, 2022
@melvin-bot melvin-bot bot added the Overdue label Sep 29, 2022
@MonilBhavsar
Copy link
Contributor

Got engaged in other priority bugs, will get back to this soon

@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2022
@Beamanator
Copy link
Contributor

It's verrrry possible this is not a bug anymore - @jasperhuangg and I recently refactored this code while adding the new API commands UpdateUserAvatar and UpdateWorkspaceAvatar - I'll check what the flows look like now

@Beamanator
Copy link
Contributor

Yeah I uploaded a new avatar in both flows, they now are consistent so I'm going to close this out, feel free to reopen if anyone disagrees

@melvin-bot melvin-bot bot reopened this Oct 6, 2022
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 6, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2022

Triggered auto assignment to @johncschuster because issue was reported by a contributor who needs to be compensated if this issue is fixed.
@Puneet-here reported this issue. Please review to confirm the PR fixes the bug / feature request they reported. If so, issue payment for reporting.

@Puneet-here
Copy link
Contributor

Hi, can we settle this as it was a valid bug report.

cc: @MonilBhavsar @johncschuster

@melvin-bot melvin-bot bot added the Overdue label Oct 13, 2022
@JmillsExpensify
Copy link

Bump on @Puneet-here's comment.

@johncschuster
Copy link
Contributor

Sorry team, I was behind here. Let me get caught up and get it settled.

@melvin-bot melvin-bot bot removed the Overdue label Oct 19, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@johncschuster
Copy link
Contributor

Job posting is here:
https://www.upwork.com/jobs/~013e47108e87e1c6b7

@Puneet-here can you apply to it so I can pay it out?

@johncschuster johncschuster added Weekly KSv2 and removed Daily KSv2 labels Oct 19, 2022
@Puneet-here
Copy link
Contributor

@Puneet-here can you apply to it so I can pay it out?

Applied just now.

@johncschuster
Copy link
Contributor

Thanks @Puneet-here! I've just sent the offer. Let me know when you accept!

@Puneet-here
Copy link
Contributor

Accepted. Thanks!

@johncschuster
Copy link
Contributor

Okey dokey! I have sent payment to @Puneet-here, the contract is complete, and the post has been closed.

Thanks for your patience while I learned the process on this one, Puneet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants