Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android/IOS - Preview page is closed for the picture which just attached without any close action #9334

Closed
kavimuru opened this issue Jun 7, 2022 · 5 comments
Assignees

Comments

@kavimuru
Copy link

kavimuru commented Jun 7, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with any account
  3. Select any chat and select plus button
  4. Select Add Attachment - Select From Glary
  5. Tap Send
  6. Open attachment again and wait

Expected Result:

Preview page is not closed for the picture which just attached

Actual Result:

Preview page is closed for the picture which just attached

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Android
  • IOS

Version Number: 1.1.73.0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+0901abb@applause.expensifail.com / Feya87Katya
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5600179_Screen_Recording_20220607-092819_New_Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Jun 7, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Jun 7, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2022

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv kbecciv changed the title Android - Preview page is closed for the picture which just attached without any close action Android/IOS - Preview page is closed for the picture which just attached without any close action Jun 7, 2022
@joelbettner
Copy link
Contributor

We found the PR that was the culprit and reverted it.

@joelbettner
Copy link
Contributor

@kavimuru now that #9343 has been deployed to staging, can you please do this test again?

@joelbettner
Copy link
Contributor

I went ahead and did the re-production steps and the bug is indeed fixed. I'm going to close this issue.

@joelbettner joelbettner removed the DeployBlockerCash This issue or pull request should block deployment label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants