[PAY RUSHAT 14TH JUL] Search - App crashed after click on Search option for specific account

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch App and login with andreylazutkinutest@gmail.com/w323052760We
2. Click Search

Expected Result:

The search result is visible after click on search

Actual Result:

App crashed after click on Search option

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.78.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): andreylazutkinutest@gmail.com/w323052760We

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5613816_Gravar__739.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

This issue is reproduced only with 1 tester, credentials: andreylazutkinutest@gmail.com/w323052760We

[rushatgabhane]

@pecanoro so I give this a quick look. ReportUtils.getChatRoomSubtitle() is returning a Number.

App/src/libs/ReportUtils.js

Line 234 in 5b0cd48

return report.oldPolicyName;

Which we're spreading over here.

App/src/libs/OptionsListUtils.js

Lines 186 to 187 in 5b0cd48

	const chatRoomSubtitle = ReportUtils.getChatRoomSubtitle(report, policies);
	searchTerms.push(...chatRoomSubtitle);

We should either convert it to a string or make sure that it isn't a string in the first place!

[pecanoro]

I am going to remove the deploy blocker since this is a super edge case. However, @rushatgabhane, since you identified the problem and you have a potential solution, I am going to assign a CME so they can open a ticket in Upwork and you can get paid for it!

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[michaelhaxhiu]

I'm OOO starting tomorrow, going to re-assign to another CM 🙏

[melvin-bot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[jliexpensify]

Posted:

Internal - https://www.upwork.com/ab/applicants/1539753155555823616/job-details
External - https://www.upwork.com/jobs/~01de01f602af88d06f

Invited @rushatgabhane for payment.

[jliexpensify]

@rushatgabhane I won't apply the exported label here, as it looks like we're just paying you $250 right? Please tag me in the Gh when you've accepted and I'll sort this out.

[MehmetFaahem]

Hey, I can solve your issue. Your Issue: button component passing an wrong parameter or cannot passing a string. It might be solved by me

[rushatgabhane]

Apologies for the delay! Working on it.

[rushatgabhane]

@MehmetFaahem thank you, I'd recommend that you go through CONTRIBUTING.md before submitting a proposal.
Look for issues with the label Help Wanted

[rushatgabhane]

@jliexpensify yes, sounds good! Accepted the offer.

Note that we might fix it at the backend #9554 (comment)

[jliexpensify]

@rushatgabhane - for this issue, are you suggesting that we wait until #9554 is resolved before deciding if we need to accept submissions?

[rushatgabhane]

@jliexpensify yeah, after that's resolved, we'll know if this needs to be fixed internally or externally.

I'll ping you regardless

[jliexpensify]

@rushatgabhane - great, let me know! I'll hold off on payment for now until we work out what needs to be done and how much we need to pay you.

[rushatgabhane]

@jliexpensify we're fixing this issue both on the frontend and backend #9554 (comment)

The PR is on staging. $250 after the regression period sounds great!

[pecanoro]

Not overdue, PR was merged 9 days ago!

[jliexpensify]

@rushatgabhane - looks like we can pay you the $250 and close this issue.

[rushatgabhane]

@jliexpensify not yet 😅

PR is not on production #9554 (comment)

[jliexpensify]

Heh, my bad: I hired you in preparation to pay you haha.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[jliexpensify]

@rushatgabhane - confirming that PR is deployed to production and I can pay you tomorrow?

[rushatgabhane]

@jliexpensify yep!

[jliexpensify]

Paid, and closed!