-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat - Sending links google.com and http://www.google.com/ appears as http:// instead of https:// #9533
Comments
Triggered auto assignment to @sakluger ( |
Triggered auto assignment to @Julesssss ( |
The links do redirect to https, but I see that we show the URL as http. I think this issue should have been raised in the PR which introduced it though. I'll link it now. |
You may have tried with popular websites like google, they won't allow 'http://' urls. Try 'http://google.com' in browser it would get automatically redirected to 'https://' site. Same happens in this case too. |
I agree the link works as expected, but it's not showing the correct URL in the tooltip. |
I think the PR fixed one case only. Posted more info in the original PR: #9471 (comment) |
@Julesssss Just now verified everything looks good for me in staging. Screen.Recording.2022-06-28.at.10.18.16.PM.mov |
Yep, I see the same thing now. Still not sure why it partially worked until now :/ |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue was found when executing #9471
Action Performed:
Expected Result:
In the chat it should appear as https://google.com/
Actual Result:
It appears as http://google.com/
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.1.78-7
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5619504_Recording__363.mp4
Expensify/Expensify Issue URL:
Issue reported by:
Applause internal team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: