Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - Sending links google.com and http://www.google.com/ appears as http:// instead of https:// #9533

Closed
kavimuru opened this issue Jun 22, 2022 · 8 comments
Assignees

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing #9471

Action Performed:

  1. Go to staging.new.expensify.com and login
  2. Send links google.com and www.google.com

Expected Result:

In the chat it should appear as https://google.com/

Actual Result:

It appears as http://google.com/

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Desktop App
  • Mobile Web

Version Number: 1.1.78-7

Reproducible in staging?: Y

Reproducible in production?: Y

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5619504_Recording__363.mp4

Expensify/Expensify Issue URL:

Issue reported by:
Applause internal team

Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Jun 22, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2022

Triggered auto assignment to @sakluger (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jun 22, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2022

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Julesssss
Copy link
Contributor

The links do redirect to https, but I see that we show the URL as http. I think this issue should have been raised in the PR which introduced it though. I'll link it now.

@Santhosh-Sellavel
Copy link
Collaborator

The links do redirect to https, but I see that we show the URL as http.

You may have tried with popular websites like google, they won't allow 'http://' urls.

Try 'http://google.com' in browser it would get automatically redirected to 'https://' site.

Same happens in this case too.

@Julesssss
Copy link
Contributor

I agree the link works as expected, but it's not showing the correct URL in the tooltip.

@Julesssss
Copy link
Contributor

I think the PR fixed one case only. Posted more info in the original PR: #9471 (comment)

@Santhosh-Sellavel
Copy link
Collaborator

@Julesssss Just now verified everything looks good for me in staging.

Screen.Recording.2022-06-28.at.10.18.16.PM.mov

@Julesssss
Copy link
Contributor

Yep, I see the same thing now. Still not sure why it partially worked until now :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants