[HOLD for payment 2022-12-08] [$250][Form Refactor] CompanyStep

[luacmartins]

Coming from the New Expensify Forms design doc, we should refactor CompanyStep to use the new form component, follow the guidelines below:

Here's an example of a Form refactor: #9056

Guidelines

1. Replace the form component with Form.js.
2. Create a unique Onyx key in ONYXKEYS.FORM and pass it as the formID prop to Form.
3. Pass a validate callback prop.
4. Pass an onSubmit callback prop that calls the API via an action.
5. Update all inputs wrapped by Form, following the guidelines in Refactor inputs.
6. Remove any unused code.

Testing

Verify that:

• UI looks as it did before the refactor
• Values can be added and edited
• Errors are highlighted correctly (input border)
• Error messages show up correctly
• Draft values are saved properly
• Form alerts are displayed correctly
• Clicking the fix the errors link focuses the first input with error
• No duplicate submission of the form occurs (when it's already submitting)

[melvin-bot]

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[adelekennedy]

@luacmartins is this something contributors can work on? Double checking before I open an Upwork job

[luacmartins]

Yes! The Form refactor project is all open to contributors :)

[luacmartins]

This issue is being put on hold due to push to page discussions, as per this comment.

[adelekennedy]

Ty ty!

[adelekennedy]

on hold

[adelekennedy]

on hold

[adelekennedy]

on hold

[luacmartins]

@adelekennedy removing hold! We can post this job on upwork and get contributors to start working on it!

[adelekennedy]

let's gooooo

[mountiny]

PR is almost merged here.

[JmillsExpensify]

Working through the commits, but looks like we should be through those really soon, ideally in the coming day or two.

[sketchydroide]

this is now merged, there were some issue gettin the commits verified, but after creating a new PR this was fixed and everyine was happy

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[sketchydroide]

there was a deploy blocker associated, but that seems to have been fixed now

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Refactor companystep to use Form -2 #13076

If no regressions arise, payment will be issued on 2022-12-08. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[mananjadhav]

@sketchydroide @luacmartins This is supposed to be paid out today, but before that I would like to request a raise for this one. This is was held for a long time for AddressForm, and went through multiple rounds for the review. Compared to average issues, this was a bit bigger.

[luacmartins]

@mananjadhav what price do you think is fair?

[adelekennedy]

pending payment on the discussion above

[mananjadhav]

I think 500$ should be fine here. Please note this also had a regression involved. So incase we don't want to increase then that is fine too.

[ravindra-encoresky]

I think 500$ should be fine here. Please note this also had a regression involved. So incase we don't want to increase then that is fine too.

I would go with the first option :) , it's been long back and forth. Thanks, looking forward.

[luacmartins]

$500 seems fair to me. Let's go with that.

[mananjadhav]

Thanks @luacmartins. @adelekennedy can you help with the payout here?

[adelekennedy]

@mananjadhav just hired you at $500

[mananjadhav]

Accepted @adelekennedy

[adelekennedy]

paid and paid!

[ravindra-encoresky]

@adelekennedy @mananjadhav I've received only $250.

[JmillsExpensify]

Re-opening until the contributor's question is answered.

[mallenexpensify]

Sorry about that @ravindra-encoresky , not sure what happened. I just bonused you $250 so total compensation is now $500. Double checked Manan's contract and the payment was $500 there, re-closing

[ravindra-encoresky]

Sorry about that @ravindra-encoresky , not sure what happened. I just bonused you $250 so total compensation is now $500. Double checked Manan's contract and the payment was $500 there, re-closing

Got it, thank you.