-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Form Refactor] ValidationStep #9582
Comments
This issue is being put on hold due to push to page discussions, as per this comment. |
On hold! |
On hold |
On hold |
On hold |
No longer on hold! |
I'll try to work on it this week! |
I'm focused on offline first and N7 issues this week. Gonna try to get to this next week. |
Prioritizing N7 issues, I'll get to this next week. |
Sorry @luacmartins , didn't have enough time to get to this before the end of last week. I'll assign it back to you so you can decide on doing it yourself or finding someone else :) |
@luacmartins I asked in slack if someone wanted to give this a try here and @youssef-lr offered to help (just letting you know) |
hey @luacmartins! I noticed that we're using |
@youssef-lr we changed to |
Thanks @luacmartins, I went ahead and updated the DD. |
Coming from the New Expensify Forms design doc, we should refactor ValidationStep to use the new form component, follow the guidelines below:
Here's an example of a Form refactor: #9056
Guidelines
Testing
Verify that:
fix the errors
link focuses the first input with errorThe text was updated successfully, but these errors were encountered: