Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Web - IOU Participants - Nothing happens when press CMD+Enter #9594

Closed
kbecciv opened this issue Jun 28, 2022 · 15 comments
Closed

[$250] Web - IOU Participants - Nothing happens when press CMD+Enter #9594

kbecciv opened this issue Jun 28, 2022 · 15 comments
Assignees
Labels
Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jun 28, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executed PR: #7702

Action Performed:

  1. Go to NewDot
  2. Click/tap on the green + icon on the home screen.
  3. Click/tap on Request Money
  4. Enter an amount and press Next
  5. Enter a search query to get a reasonable-length list of results.
  6. Use the arrow keys to highlight different result.
  7. Press CMD+Enter.

Expected Result:

After Press CMD+Enter it should take you to the next page with your new selected user.

Actual Result:

When Press CMD+Enter nothing happens.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.79.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): rybkina+061322@gmail.com/Qwerty123

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Bug5628527_step9_.mp4

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jun 28, 2022

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@rushatgabhane
Copy link
Member

rushatgabhane commented Jun 29, 2022

This is the expected UX for lists with untoggleable items

cc @roryabraham thoughts?

@sketchydroide sketchydroide added the DeployBlockerCash This issue or pull request should block deployment label Jun 29, 2022
@sketchydroide
Copy link
Contributor

I'm adding a deploy blocker has this seems to block the QA of #7702 and therefor blocking the deployment

@roryabraham
Copy link
Contributor

This is the expected UX for lists with untoggleable items

Agree, this is how it was designed so I wouldn't say it counts as a regression or deploy blocker. If we want to make CMD+Enter work just like Enter for lists that don't support multiple selections, that's a new feature. It seems like a good idea to me but can be treated as separate

@roryabraham roryabraham removed the DeployBlockerCash This issue or pull request should block deployment label Jun 29, 2022
@roryabraham roryabraham reopened this Jun 29, 2022
@roryabraham
Copy link
Contributor

This can also be external

@rushatgabhane
Copy link
Member

@roryabraham what problem is this feature request trying to solve?

Is it something like other similar pages allow cmd+enter to go next, so we should implement that pattern here too?

@roryabraham
Copy link
Contributor

Is it something like other similar pages allow cmd+enter to go next, so we should implement that pattern here too?

Yeah, exactly

@madmax330
Copy link
Contributor

Alright passing this on as external, thanks @roryabraham

@madmax330 madmax330 added Weekly KSv2 External Added to denote the issue can be worked on by a contributor and removed Daily KSv2 labels Jun 30, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 30, 2022

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 30, 2022
@laurenreidexpensify
Copy link
Contributor

@melvin-bot
Copy link

melvin-bot bot commented Jun 30, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 30, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 30, 2022

Triggered auto assignment to @pecanoro (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title Web - IOU Participants - Nothing happens when press CMD+Enter [$250] Web - IOU Participants - Nothing happens when press CMD+Enter Jun 30, 2022
@roryabraham
Copy link
Contributor

I'm actually going to just fix this myself because it's come up a few times and it will be a really quick and easy fix

@roryabraham roryabraham removed Help Wanted Apply this label when an issue is open to proposals by contributors External Added to denote the issue can be worked on by a contributor labels Jul 1, 2022
@roryabraham
Copy link
Contributor

@laurenreidexpensify I took down the upwork job for this

@roryabraham
Copy link
Contributor

Got a PR up

@roryabraham roryabraham added the Reviewing Has a PR in review label Jul 1, 2022
@melvin-bot melvin-bot bot closed this as completed Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants