Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Confirmation List - The participant isn't shown after press the ArrowUp key #9595

Closed
kbecciv opened this issue Jun 28, 2022 · 6 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Jun 28, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executed PR: #7702

Action Performed:

  1. Go to NewDot
  2. Open a 1:1 DM with another user (not Chronos or Concierge).
  3. Press the + button in the compose bar and click Request Money
  4. Enter an amount and press Next
  5. Press the ArrowUp key to highlight your participant.

Expected Result:

The participant should be show base on step 19 IOU Confirmation List/ Web/Desktop.

Actual Result:

The participant isn't shown.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.79.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): rybkina+061322@gmail.com/Qwerty123

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5628540_enter.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jun 28, 2022

Triggered auto assignment to @TomatoToaster (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@rushatgabhane
Copy link
Member

rushatgabhane commented Jun 29, 2022

@kbecciv I'm confused here. We're requesting money to Holla Ryba and the same user is shown on the confirm page.
Can you help me understand what's the bug here?

@kavimuru
Copy link

kavimuru commented Jun 30, 2022

@rushatgabhane This issue was found when executing #7702. Might be there is a mistake in the steps

Web/Desktop

  • Open a 1:1 DM with another user (not Chronos or Concierge).
  • Press the + button in the compose bar and click Request Money
  • Enter an amount and press Next
  • Press the ArrowUp key to highlight your participant.
  • Press Enter. The IOU should be created.

@rushatgabhane
Copy link
Member

rushatgabhane commented Jun 30, 2022

Press the ArrowUp key to highlight your participant.

@kavimuru Thanks the clarification. This step should be ignored / removed.
cc @roryabraham

@roryabraham
Copy link
Contributor

Oh, you're correct that this is a mistake in the QA steps that are out-of-date. Let me update the steps and close this issue.

@roryabraham
Copy link
Contributor

Updated the QA steps to remove the Press the ArrowUp key to highlight your participant. If you are coming from global create or a 1:1 DM, then you can't modify the IOU participants in the IOUConfirmationList. If you can't modify the participants, then the arrow keys shouldn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants