Search - Focus moves to the 1st line of results when the search query

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue was found when executing PR #7702

Action Performed:

1. Open App
2. Open Search
3. Type search query
4. Focus somewhere in the middle of the list
5. Update the search input such that there are no results
6. Undo the change from the previous step

Expected Result:

The focus should be where you left it

Actual Result:

Focus moves to the 1st line of results when the search query

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.79.13

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5636132_PR7702-search-focus.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

Added Deploy blocker label because the issue is not reproduced in production.

Recording.709.mp4

[isagoico]

When retesting #7702 for #9672.
We found that the issue described in the OC fails step #8 and #10 under the scenario Search page / Web-Desktop

I'm not sure if this needs to be a blocker or if it can be addressed later so we're leaving the deploy blocker label for review.

[rushatgabhane]

Thanks @isagoico, this is the expected result and not a blocker.

The tests are outdated. Sorry about that!

cc: @roryabraham

[isagoico]

Thank you for confirming @rushatgabhane!

@roryabraham I created a ticket to get the PR steps added to the regression here https://github.com/Expensify/Expensify/issues/217359. We'll need to modify some steps to match the expected behavior since some tests are outdated. I will review the whole flow today and post the inconsistencies there for review.

[roryabraham]

Thanks, @rushatgabhane is correct that this is the expected behavior. Whenever the search term changes we highlight the first option because it theoretically is the Best Result™ according to the latest search query. Thanks and sorry for the out-of-date QA steps.