Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2022-07-18 #9970

Closed
49 of 79 tasks
OSBotify opened this issue Jul 18, 2022 · 38 comments
Closed
49 of 79 tasks

Deploy Checklist: New Expensify 2022-07-18 #9970

OSBotify opened this issue Jul 18, 2022 · 38 comments
Assignees
@luacmartins @applausebot
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jul 18, 2022 •
edited by mvtglobally
Loading

Release Version: 1.1.85-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jul 19, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.85-2 🚀

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.85-3 🚀

@Julesssss
Copy link
Contributor

I added the deploy blocker label to this issue as a few of us noticed it this morning. It's difficult to reproduce though, so it may well have been from a previous version.

@marcaaron
Copy link
Contributor

marcaaron commented Jul 19, 2022 •
edited
Loading

It's difficult to reproduce though, so it may well have been from a previous version.

it's in this version and introduced by a change in #9560. fix incoming!

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.85-3 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.85-4 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.85-4 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.85-5 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.85-5 has been deployed to staging 🎉

@roryabraham
Copy link
Contributor

Checking off #9641 because it passed internal QA

@mvtglobally
Copy link

mvtglobally commented Jul 20, 2022 •
edited
Loading

Regression is completed
Open Blockers
#10016
#10021
#10024
#10038

PR #9607 is failing due to #9992. We retested its pass - checking off
PR #9642 is failing due to #10018. Not a blocker checking off
PR #9697 is failing due to #10010. Not a blocker checking off
PR #9828 is failing due to #10021.
PR #9840 is failing due to #10022 Not a blocker checking off
PR #9878 is failing due to #10001. We are retesting and will check off

Working on few New CPs will share updated list in a bit.

Additional issues logged
#10009
#10010
#10017
#10018
#10022
#10029
#10031
#10032
#10034
#10036

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Jul 20, 2022 •
edited
Loading

Hi! I was assigned to #10034, and it appears to me that it isn't actually a bug I've given an explanation here and have closed it out.

@mvtglobally
Copy link

To summarize outstanding issues
PR #10008 is failing due to #10016 blocker
PR #9828 is failing due to #10021
and open Blockers
#10016
#10021
#10024
#10038

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.85-6 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.85-6 has been deployed to staging 🎉

@mountiny
Copy link
Contributor

@mvtglobally I believe a fix for another deploy blocker also fixed this one: #10016. Can you please re-test it on the latest staging version?

@Julesssss
Copy link
Contributor

I checked off #10024 as a blocker, and asked for applause to retest it.

@chiragsalian
Copy link
Contributor

chiragsalian commented Jul 21, 2022 •
edited
Loading

Posting a summary to keep track,

@mvtglobally, can you re-test the following and update the checklist when you get the chance,

  1. Add 'OpenIOUDetailsPage' API command #9878 now that IOU Request - Error "Invalid onyxMethod mergecollection in Onyx update." appeared in Console #10001 has passed.
  2. iOS - IOU - Preview component - Crash after tapping on the' Pay' or 'View details' buttons #10016
  3. Update Onyx to 1.0.10 #10008
  4. [CP Stag] Fix lodashGet usage #10043
  5. Desktop - Money request - Onyx JS errors after few requests to the new user and blank chat #10038
  6. Web: Report comment date & time always shows Today, at current time (not when comment was sent) #10042 (looks like it should be resolved because of [CP Stag] Fix lodashGet usage #10043)
  7. Messages are being lost and fail to send #10000

I'll discuss the following with my team to get movement on it,

  1. Android - Payments - Default payment is disappearing after closed and re-open the app. #10021

Misc,

  1. I noticed iOS - IOU - Preview component - Crash after tapping on the' Pay' or 'View details' buttons #10016 was tested so i'll check it off in the checklist.

@mvtglobally
Copy link

@chiragsalian We will check and update

@mvtglobally
Copy link

#10024 fixed. Checking off

@mvtglobally
Copy link

mvtglobally commented Jul 21, 2022 •
edited
Loading

#10016 (comment) - FIXED
#10043 - Is still happening only with some accounts. Do we want to checkoff or track as blocker?
#10038 (comment) - FIXED

@chiragsalian
Copy link
Contributor

chiragsalian commented Jul 21, 2022 •
edited
Loading

So for #10043, you mention its happening only with some accounts. For the accounts facing the problem is the issue also happening on production or just staging? I believe its both but can you confirm. If so feel free to check off #10043 and we'll use #10046 to track the issue.

@mvtglobally
Copy link

mvtglobally commented Jul 21, 2022 •
edited
Loading

@chiragsalian You are right. Tester checked and its repro in PROD as well

Finishing up few outstanding retests now and will update in a bit
Checking off #10000 (comment)

@chiragsalian
Copy link
Contributor

I'm checking off #10021 and #9828 since its working on gold wallet accounts. We've asked for further clarification in the issue on how to handle it better for silver wallet accounts.

@chiragsalian
Copy link
Contributor

Okay so i think thats all from our side. Let us know when you are done testing if there is anything we are missing to tackle.

@mvtglobally
Copy link

mvtglobally commented Jul 21, 2022 •
edited
Loading

@chiragsalian
#10008 retested - passed
#9878 retested - Passed
#10043 is still failing with some accounts. Should I check off as its repro in PROD??

@chiragsalian
Copy link
Contributor

chiragsalian commented Jul 22, 2022 •
edited
Loading

Yup, i'll check off #10043 as its reproducible on production and we have #10046 to track the issue anyway.
Edit: i checked off #10042 as well since it was just the issue for the #10043 PR.

@mvtglobally
Copy link

@chiragsalian Do you think we may have deploy today or next week now only?

@mountiny
Copy link
Contributor

@chiragsalian I think the last open deploy blocker does not necessarily have to be a deploy blocker as it is a console error however, it seems to not influence the App functionality. Still investigating, it must be related to some updated API.

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.85-8 🚀

@chiragsalian
Copy link
Contributor

chiragsalian commented Jul 22, 2022 •
edited
Loading

@mvtglobally, sorry for the delayed reply. We won't be deploying today. Our next deploy should be on monday.

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.85-8 has been deployed to staging 🎉

@luacmartins luacmartins self-assigned this Jul 25, 2022
@melvin-bot melvin-bot bot added the Monthly KSv2 label Jul 25, 2022
@luacmartins
Copy link
Contributor

@mvtglobally is QA done for #9956?

@mvtglobally
Copy link

Checking. Will update in a few

@luacmartins luacmartins added Daily KSv2 and removed Monthly KSv2 labels Jul 25, 2022
@luacmartins
Copy link
Contributor

Everything else looks good. Just waiting on QA confirmation for #9956 and we should be good to deploy!

@mvtglobally
Copy link

@luacmartins checking off #9956

@luacmartins
Copy link
Contributor

luacmartins commented Jul 25, 2022 •
edited
Loading

Cool! Checklist is clear and dashboards look good. Kicking off the deploy.

@luacmartins
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luacmartins luacmartins

@applausebot applausebot

Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@Julesssss @chiragsalian @luacmartins @jasperhuangg @marcaaron @mountiny @applausebot @mvtglobally @roryabraham @OSBotify