#3102 add accessibility role and label to close button

[dklymenk]

Details

Simple addition off accessibility props.

Fixed Issues

Fixes #3102

Tests / QA Steps

1. Turn on Screen Reader or Voiceover
2. Launch the Expensify.cash app or website
3. Swipe or click into any menu that has an X "close" button. For example:
   ( + ) > New Chat > X
   ( + ) > Request Money > X
   ( + ) > New Group > X
   tap avatar icon > X
   tap search mag icon > X
4. Make sure that the X "Close" button has a role and a label.

Tested On

• Web - Windows/JAWS/Firefox - MACOs/Voiceover/Safari
• Mobile Web
• Desktop - Voiceover
• iOS - iOS/Voiceover
• Android - Android/Talkback

I do not own a physical iPhone and there is no Voiceover on iOS simulator, so I am unable to test accessibility features on iOS app.

Screenshots

Web

win10.mp4

mac1.mp4

Mobile Web

mweb.mp4

Desktop

electron.mp4

iOS

Android

android.mp4

[mountiny]

Tested on Desktop, Web and tested in ios simulator using this approach although I am not sure if it is bulletproof. Unfortunately, I do not have Android phone and I do not have certificates et up yet to test it on my phone. I have requested the certificates.

[OSBotify]

🚀 Deployed to staging in version: 1.0.62-6🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production in version: 1.0.64-0🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[iwiznia]

You added a new language key in this PR but you only added it to the en language. We need to add it to the es language too. Close in spanish is Cerrar, can you please submit a PR adding it @dklymenk?

[dklymenk]

Ok, I'll submit a PR as soon as I can.

Meanwhile, you might also want to take a look at this MR - https://github.com/Expensify/Expensify.cash/pull/3285/files

It also makes accessibility changes and adds translations for EN only.

[iwiznia]

Yep, thanks for that link!

[dklymenk]

@iwiznia Please find PR with missing translation here #3525

[iwiznia]

Thanks! I approved it already.