Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Add a beta for the free plan #3401

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Jun 7, 2021

This is needed for n5.5, the free plan. Nothing uses this yet, it will be tested in future PRs.

Fixed Issues

Part of https://github.com/Expensify/Expensify/issues/166446

Tests

None

QA Steps

None

Tested On

n/a

Screenshots

n/a

@tgolen tgolen requested a review from a team June 7, 2021 16:46
@tgolen tgolen self-assigned this Jun 7, 2021
@MelvinBot MelvinBot requested review from HorusGoul and removed request for a team June 7, 2021 16:47
@marcaaron
Copy link
Contributor

Gonna merge this so we can start to put NewDot issues behind a beta. There's a lot of stuff on hold that we can probably start scaffolding out ASAP.

@marcaaron marcaaron merged commit f102a3e into main Jun 7, 2021
@marcaaron marcaaron deleted the tgolen-freeplan-beta branch June 7, 2021 23:37
@OSBotify
Copy link
Contributor

OSBotify commented Jun 7, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Jun 8, 2021

🚀 Deployed to staging in version: 1.0.64-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jun 8, 2021

🚀 Deployed to production in version: 1.0.65-0🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Julesssss
Copy link
Contributor

Julesssss commented Jun 9, 2021

Due to an unfortunate conflict, a regression to the IOU feature was caused by this PR.

@parasharrajat's PR modified the permissions logic, removing the betas subscription from the Permissions.js file at the same time that you added a new beta flag using the existing pattern.

Steps to reproduce

  • Send an IOU Request to a user with a USD personal policy currency
  • Login as the user with a USD personal policy currency
  • Attempt to open the IOU Details Modal

Screenshot 2021-06-09 at 14 49 12

@Julesssss
Copy link
Contributor

Due to the urgency of this IOU blocker, I'll raise the PR. No need to worry about this.

@parasharrajat
Copy link
Member

@Julesssss Just noticed that this causing lint check failure on other PRs.

@Julesssss
Copy link
Contributor

PR: #3481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants