Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix web markdown input layout when entering newlines #165

Closed
Skalakid opened this issue Feb 8, 2024 · 1 comment
Closed

Fix web markdown input layout when entering newlines #165

Skalakid opened this issue Feb 8, 2024 · 1 comment
Assignees
@Skalakid
Labels
bug Something isn't working

Comments

@Skalakid
Copy link
Collaborator

Skalakid commented Feb 8, 2024

Objective

Enhance how numberOfLines prop works and how it limits/sets the height of contentEditable element. After every render markdown input sets it's height to auto and we are resetting it to our calculated value, which causes the above problem.

Current state

After entering text with markdown, changing the numberOfLines prop when entering a new line, causes problems with the layout. The input is flickering and jumping at the top.

web-bug.mov
@Skalakid Skalakid added the bug Something isn't working label Feb 8, 2024
@Skalakid Skalakid self-assigned this Feb 8, 2024
@Skalakid
Copy link
Collaborator Author

Skalakid commented Apr 30, 2024 •
edited
Loading

Fixed in E/App - Expensify/App#40128. Closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skalakid Skalakid

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Skalakid