Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Next.js #56

Open
grez96 opened this issue Jul 8, 2021 · 2 comments
Open

Integrate Next.js #56

grez96 opened this issue Jul 8, 2021 · 2 comments
Assignees
@grez96

Comments

@grez96
Copy link
Contributor

grez96 commented Jul 8, 2021

Use Next.js in react-ui so the Button/Link component can be easier to integrate.
@grez96 grez96 self-assigned this Jul 8, 2021
@jmckinnell
Copy link
Member

I'm of the opinion that we should keep react-ui platform agnostic. Button and Link are easy enough to include in the boiler-plate and any style/animation based components can just wrap the button etc.

@grez96
Copy link
Contributor Author

grez96 commented Jul 19, 2021 •
edited
Loading

I agree keeping react-ui platform agnostic is best. Maybe we can add Next.js as a peer dependency, that way these components can just import ex. import Link from 'next/link'. Doing this the components will become super easy plug and play.
Curious why this PR that moved react-router to peer dependencies was closed?

Maybe we can also build component variations?

  • Button_NextJS
  • Button_CRA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grez96 grez96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmckinnell @grez96