Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local build ignores build flag in user_defines #695

Open
slackista opened this issue Oct 23, 2024 · 3 comments
Open

Local build ignores build flag in user_defines #695

slackista opened this issue Oct 23, 2024 · 3 comments

Comments

@slackista
Copy link

Current Behavior

Local build ignores build flag -DRegulatory_Domain_EU_868

Steps to Reproduce

  1. Select Git branch tab
  2. Select master branch
  3. Target: radiomaster.tx_dual.nomad.uart
  4. Manual mode:
-DMY_BINDING_PHRASE="secret"
-DRegulatory_Domain_EU_868
-DUART_INVERTED
  1. Logs don't print build_flags
  2. Build and flash finishes without errors
  3. TX is flashed successfully with AU915 reg domain

Details

Configurator v1.7.6
Reproducible on ArchLinux and Debian11

@pkendall64
Copy link
Contributor

Can you attach the log from the build please?

@slackista
Copy link
Author

Build logs. Vanilla Ubuntu24.04.1
expressslrs-configurator.log

@pkendall64 pkendall64 transferred this issue from ExpressLRS/ExpressLRS Oct 25, 2024
@pkendall64
Copy link
Contributor

pkendall64 commented Oct 25, 2024

@jurgelenas The issue here is that after the firmware has been built, configurator is calling the binary_configurator.py script and it can't set the options because they are defines in the manual mode text box. Basically when doing a local build of firmware configurator should not be calling the configurator as all the values should be set in place by the platformio build.

This will affect all locally built firmwares from the "git" and "local" tabs in configurator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants