-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regular expression support #450
Comments
Hey @scarf005, this is a neat idea, but do you have any thoughts on how to determine whether a scope that a user has provided is a regex or not? Maybe as well as the Do you have any thoughts on this, or suggestions for a better way of handling it? |
i think scopeRrgexes could work |
@Ezard Any plans to implement this? I am also looking for regex support for scopes. |
Had a think about this today, and unfortunately allowing users to specify their own regexes opens things up for abuse (there are some things that you can do with regexes that require loads of computational power; see here for examples) I would be open to something a bit more constrained though, e.g.
or something like this, if that would be suitable? |
hi, i'd like to apply conventional PR titles for our project, and thought it'd be neat to define valid scopes by regex. for example:
would match titles such as
i'm interested in opening a PR for this feature.
relevent lines:
semantic-prs/functions/src/is-message-semantic.ts
Lines 36 to 37 in 2915f0c
The text was updated successfully, but these errors were encountered: