Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression on dependabot PR ? #754

Closed
benoitf opened this issue Dec 30, 2024 · 7 comments
Closed

regression on dependabot PR ? #754

benoitf opened this issue Dec 30, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@benoitf
Copy link

benoitf commented Dec 30, 2024

Describe the bug

hello,

I'm using the app to check PRs and it was working fine for months but since today, dependabot PRs are all failing on semantic checks

podman-desktop/podman-desktop#10483

so I'm wondering if there is a regression in latest commits ?

semantic.yml contents

enabled: true
titleAndCommits: true
allowMergeCommits: true

Sample PR Title(s) (if relevant)

chore(deps-dev): bump octokit from 4.0.2 to 4.0.3

PR is there: podman-desktop/podman-desktop#10483

Sample Commit Message(s) (if relevant)

chore(deps-dev): bump octokit from 4.0.2 to 4.0.3
Bumps [octokit](https://github.com/octokit/octokit.js) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/octokit/octokit.js/releases)
- [Commits](https://github.com/octokit/octokit.js/compare/v4.0.2...v4.0.3)

---
updated-dependencies:
- dependency-name: octokit
  dependency-type: direct:development
  update-type: version-update:semver-patch

commit is there: https://github.com/podman-desktop/podman-desktop/pull/10483/commits

@benoitf benoitf added the bug Something isn't working label Dec 30, 2024
@Ezard
Copy link
Owner

Ezard commented Dec 30, 2024

Hey @benoitf, thanks for the report!

There was indeed an issue with a recent deployment, but I rolled it back after I spotted it; the issue was around between 18:00 (UTC) on the 29th and 02:00 on the 30th

If a PR was created or edited during this time then it would've been affected; you can get the check to run again by editing the PR in some way (e.g. by changing the title of it)

Let me know if you're still seeing issues!

@benoitf
Copy link
Author

benoitf commented Dec 30, 2024

hello @Ezard thanks for your reply

On my end I still see the issue (I created a new PR 1 hour ago)
podman-desktop/podman-desktop#10490

I also asked dependabot to rebase its PR few minutes ago podman-desktop/podman-desktop#10483 (comment) and it's still failing (Semantic check is a red cross)

@maxrake
Copy link

maxrake commented Dec 30, 2024

+1 still appears to be an open issue.

@jusiskin
Copy link

Our GitHub repositories use this GitHub action are also seeing failed Semantic PR checks despite the commit and PR title following the correct format. We've had to turn off the required PR check to bypass the false-positive failures.

Is there any progress investigating/resolving this?

@Ezard
Copy link
Owner

Ezard commented Dec 31, 2024

@benoitf @maxrake @jusiskin I've now rolled back to the last known good version - let me know if that resolves things for you

I'll leave this issue open for the moment; when I've got some new infrastructure set up for testing deployments on a per-repo basis, would any of you be up for trialling a fixed version on your repo before it gets fully rolled out please?

@Slartibartfass2
Copy link

@Ezard it worked for me now.
Thanks 👍🏼

@benoitf
Copy link
Author

benoitf commented Jan 1, 2025

@Ezard I confirm now it works again, thanks

And yes I should be able to try things

@benoitf benoitf closed this as completed Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants