-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requesting support for new CKAN User-Agent strings on kerbaltek.com #75
Comments
Hi, @HebaruSan! Thanks for coming here to tell me about this. I really appreciate it. I've added the new agents. Please test it when you can. |
Hi @Ezriilc, Thanks for the quick response! The special
|
DRAT! I thought that may have been too easy. Working... |
FYI, we are still chatting about the possibility of tweaking the strings I gave a little; @DasSkelett wants to add |
Sorry for that. I THINK I have it fixed now.
I've modified my code to allow easy changes and additions to both CKAN and NETKAN user agents. Feel free to update me whenever a change is made. |
Thanks! The description now has the latest strings (added The
|
Sorry, but isn't the 'http(s)' part at your end? I'll have to take up this fix a bit later today. |
As far as I can tell, no, the server is doing that:
|
The currently live version of the bot (using the old useragent, working before I submitted this) is also failing with a 404. |
I meant that NETKAN/CKAN should be calling https, and not http. I can't control how they call the URL. However, you should not be getting the 403/404 errors, so I'll get on that later today. Sorry! |
I just thought that that's probably in my .version file or some such. Later... |
Oh, the mods' .netkan files start us out on |
My code is checking the IP address of NETKAN. Is that a problem? |
Also, I've been separating things based on the CKAN app vs the NETKAN bot. Is sensible? I'm ready for you to do a test again, when you can. Thanks. |
Oh, maybe that's why I still get a 403 response when testing the new strings from my own computer. Which IP addresses are you allowing? The parts of the bot will run from inside the current AWS containers and (less often) some GitHub Action containers, so I would want to make sure neither of those is blocked. The old string seems to be working again, though, so that's good. 👍 |
IF you'd like to give me a list of confirmed IP addresses to allow, I can do that. However, I don't understand why the new strings aren't being approved, but the old is. They're all looked at the same way. |
Hmm, apparently that's not recommended:
So I guess the simple answer to "Is that a problem?" was "Yes."
Hmm, I'm not going to be able to point out what's causing it without seeing your code and server setup, but the first useragent listed in the description currently works, and the others return 403 Forbidden. |
Drat. That is a bit of a security problem, but not a big one. I've disabled that check.
Yep, that one's on me. I'm sorta thinking out loud to let you know where I am. Working... |
I THINK I have the 404 errors fixed. Please test when you can. |
Hi, thanks for the response. I'm still seeing the same errors.
The old useragent still works. |
I'm very sorry for all the trouble, and I'm grateful for all your feedback and efforts to help me. I've made some changes, and if you could please try again, it will help me to figure out what's wrong. THANKS! |
It's no problem at all, I am as familiar with the change-test-fix cycle as anyone. 😀 With the latest changes, it works for me with any useragent; after I tried the ones we plan to use, I tested with |
OK, confirmed that the |
I was wondering if caching might be the issue. Shall I put it back to see if that's it? |
I don't know what you'd be putting back, but I've confirmed that client-side caching isn't the cause of what I'm seeing. |
We've switched over to the new strings and everything seems to be working, so we can consider this resolved for now. Thanks for your help! |
Hi @Ezriilc!
We'd like to update the
User-Agent
strings that some CKAN bots and utilities use (see KSP-CKAN/CKAN#3490, KSP-CKAN/xKAN-meta_testing#84, and KSP-SpaceDock/SpaceDock#436), and we are aware this would break HyperEdit and Graphotron:Could you please update your site to treat all three of these as CKAN? The old one is not being removed, just supplemented:
Mozilla/4.0 (compatible; CKAN)
Mozilla/5.0 (compatible; Netkanbot/1.0; CKAN; +https://github.com/KSP-CKAN/xKAN-meta_testing)
Mozilla/5.0 (compatible; Netkanbot/1.0; CKAN; +https://github.com/KSP-CKAN/NetKAN-Infra)
If you have any questions, I'll do my best to answer them. Thanks!
The text was updated successfully, but these errors were encountered: