Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_elevated conflicts with the "Add Mark to Log" shortcut #236

Closed
1 of 3 tasks
FPtje opened this issue Aug 22, 2024 · 2 comments
Closed
1 of 3 tasks

is_elevated conflicts with the "Add Mark to Log" shortcut #236

FPtje opened this issue Aug 22, 2024 · 2 comments

Comments

@FPtje
Copy link

FPtje commented Aug 22, 2024

Defect

Take the example from the documentation:

processes:
  elevated_ls:
    description: "run an elevated process"
    command: "ls -l /root"
    is_elevated: true
    shutdown:
      signal: 9
  • Try to run the process
  • See a little pop up saying you need to enter the sudo password
  • Try to type the letter m
  • See that no letter is actually typed
  • Do witness a mark in your log!

The reason for this is that there is a default shortcut for m, which is Add Mark to Log. I think shortcuts should be temporarily suspended (except for maybe the Escape key) when the password pop up box is open :)


Make sure that these boxes are checked before submitting your issue -- thank you!

  • Included the relevant configuration snippet
  • Included the relevant process-compose log (log location: process-compose info)
    • The log does not show anything relevant
  • Included a [Minimal, Complete, and Verifiable example] (https://stackoverflow.com/help/mcve)
    • The example from documentation is minimal enough.

Version of process-compose:

Version v1.24.0

OS environment:

Ubuntu 22.04

Steps or code to reproduce the issue:

See above

Expected result:

The letter M being typed, and no mark being added

Actual result:

A mark being added, and the letter M not being typed

@F1bonacc1
Copy link
Owner

Thanks for letting me know.
Fixed in v1.24.2

@FPtje
Copy link
Author

FPtje commented Aug 22, 2024

Wow, that's quick! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants