Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when a task is disabled, the terminal window hangs after quitting #239

Closed
3 tasks done
thenbe opened this issue Aug 29, 2024 · 1 comment
Closed
3 tasks done

when a task is disabled, the terminal window hangs after quitting #239

thenbe opened this issue Aug 29, 2024 · 1 comment
Labels
bug Something isn't working done Done, awaiting release

Comments

@thenbe
Copy link

thenbe commented Aug 29, 2024

Defect

Make sure that these boxes are checked before submitting your issue -- thank you!

  • Included the relevant configuration snippet
  • Included the relevant process-compose log (log location: process-compose info)
  • Included a [Minimal, Complete, and Verifiable example] (https://stackoverflow.com/help/mcve)

Version of process-compose:

1.24.0

OS environment:

  • system: "x86_64-linux"
  • host os: Linux 6.6.47, NixOS, 24.11 (Vicuna), 24.11.20240821.c374d94

Steps or code to reproduce the issue:

version: "0.5"

processes:
  api:
    disabled: true # <-- The bug only occurs when this is set to `true`
    command: echo hello
  1. Use the config posted above.
  2. Run process-compose up --keep-project
  3. Attempt to quit process-compose by pressing F10 then enter.
  4. .
    • EXPECTED: process-compose should quit and you should be able to use the shell. You can run echo foo in the same shell. Pressing ctrl+c enters a "new line".
    • ACTUAL: process-compose quits, but the shell is not in a usable state. You are not able to run a command in the same shell. Pressing ctrl+c prints the literal characters ^C on the screen.

Logs

24-08-29 08:00:03.984 INF Process Compose v1.24.0
24-08-29 08:00:03.984 INF Loaded project from /home/nbe/projects/sail/process-compose.yaml
24-08-29 08:00:03.984 INF Global shell command: bash -c
24-08-29 08:00:03.984 INF start http server listening :8080
24-08-29 08:00:03.984 DBG Spinning up 0 processes. Order: []
24-08-29 08:00:03.984 INF Project completed
24-08-29 08:00:03.984 DBG Loaded settings from /home/nbe/.config/process-compose/settings.yaml
24-08-29 08:00:03.985 DBG Shortcuts loaded from /home/nbe/.config/process-compose/shortcuts.yaml
24-08-29 08:00:06.793 DBG Shutting down 0 processes. Order: []
24-08-29 08:00:06.794 INF Thank you for using process-compose

If you have difficulty reproducing this, let me know and I'll record a video.

@thenbe
Copy link
Author

thenbe commented Aug 29, 2024

I noticed that if I change the value of disabled to false, the issue does not occur; everything works as expected.

version: '0.5'

processes:
  api:
-    disabled: true
+    disabled: false
    command: echo hello

Here are the logs:

24-08-29 08:04:06.147 INF Process Compose v1.24.0
24-08-29 08:04:06.147 INF Loaded project from /home/nbe/projects/sail/process-compose.yaml
24-08-29 08:04:06.147 INF Global shell command: bash -c
24-08-29 08:04:06.147 INF start http server listening :8080
24-08-29 08:04:06.147 DBG Spinning up 1 processes. Order: ["api"]
24-08-29 08:04:06.147 DBG Loaded settings from /home/nbe/.config/process-compose/settings.yaml
24-08-29 08:04:06.147 INF Started command=["bash","-c","echo hello"] process=api
24-08-29 08:04:06.148 DBG Shortcuts loaded from /home/nbe/.config/process-compose/shortcuts.yaml
24-08-29 08:04:06.198 INF Exited exit_code=0 process=api
24-08-29 08:04:06.198 INF Project completed
24-08-29 08:04:07.778 DBG Shutting down 0 processes. Order: []
24-08-29 08:04:08.779 DBG Logs monitoring canceled
24-08-29 08:04:08.779 INF Thank you for using process-compose

Could this line be significant? It does not appear when disabled is set to true.

24-08-29 08:04:08.779 DBG Logs monitoring canceled

@F1bonacc1 F1bonacc1 added bug Something isn't working done Done, awaiting release labels Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done Done, awaiting release
Projects
None yet
Development

No branches or pull requests

2 participants