You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it is a bit problematic to store the path to the cif file in the .pc file, because the location of one file relative to the other might change and then the .pc file has to be modified with the new path.
If I am not wront, the only reason for this cif path to exist is to compute the structure factors, but I think this computation could be done during the creation of the .pc file and then the .pc file is independent from the cif file then on.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
FABLE-3DXRD
-
Hi all,
I think it is a bit problematic to store the path to the cif file in the .pc file, because the location of one file relative to the other might change and then the .pc file has to be modified with the new path.
If I am not wront, the only reason for this cif path to exist is to compute the structure factors, but I think this computation could be done during the creation of the .pc file and then the .pc file is independent from the cif file then on.
What do you think @AxelHenningsson ?
PD: I know my branch has been open for a long while but I promise I am making an effort to close it.
Beta Was this translation helpful? Give feedback.
All reactions