Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double negative variable name #70

Open
ZooeyMiller opened this issue Mar 31, 2017 · 0 comments
Open

Double negative variable name #70

ZooeyMiller opened this issue Mar 31, 2017 · 0 comments

Comments

@ZooeyMiller
Copy link

Here (line 56 src/handlers.js) you declare a variable headerNotSet to true, then set it as false when the header has been set.
I found the use of double negative a little bit jarring, perhaps you could call it headerSet and set it as false and then set it as true when you've set the header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant