You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
USERNAME_CHANGE_TOO_EARLY(139, "Username change not allowed", "Only one name change per 30 days is allowed. {0, number} more days to go."),
Change To:
USERNAME_CHANGE_TOO_EARLY(139, "Username change not allowed", "Only one name change per 90 days is allowed. {0, number} more days to go."),
Further Suggestion/Thoughts:
I believe the hard coded number related to "per xx days" can even be completely removed, because if you go to the homepage to rename yourself, you already can see the limits at first glance:
To avoid duplicating hard-coded numbers across the website and faf-java-api, we could replace them with a single source of truth and just go with something like, e.g.:
USERNAME_CHANGE_TOO_EARLY(139, "Username change not allowed", "You are able to change your name again in {0, number} days"),
The text was updated successfully, but these errors were encountered:
Issue: Wrong number, should 90 instead 30: (flash error message from website)
Currently:
faf-java-api/src/main/java/com/faforever/api/error/ErrorCode.java
Line 48 in 4fc50f1
Change To:
USERNAME_CHANGE_TOO_EARLY(139, "Username change not allowed", "Only one name change per 90 days is allowed. {0, number} more days to go."),
Further Suggestion/Thoughts:
I believe the hard coded number related to "per xx days" can even be completely removed, because if you go to the homepage to rename yourself, you already can see the limits at first glance:
To avoid duplicating hard-coded numbers across the
website
andfaf-java-api
, we could replace them with a single source of truth and just go with something like, e.g.:USERNAME_CHANGE_TOO_EARLY(139, "Username change not allowed", "You are able to change your name again in {0, number} days"),
The text was updated successfully, but these errors were encountered: