Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Username Change Interval Text Message from 30 to 90 Days (or remove it) #903

Open
magge-faf opened this issue Oct 29, 2024 · 0 comments

Comments

@magge-faf
Copy link

Issue: Wrong number, should 90 instead 30: (flash error message from website)

image

Currently:

USERNAME_CHANGE_TOO_EARLY(139, "Username change not allowed", "Only one name change per 30 days is allowed. {0, number} more days to go."),

Change To:

USERNAME_CHANGE_TOO_EARLY(139, "Username change not allowed", "Only one name change per 90 days is allowed. {0, number} more days to go."),

Further Suggestion/Thoughts:

I believe the hard coded number related to "per xx days" can even be completely removed, because if you go to the homepage to rename yourself, you already can see the limits at first glance:

image

To avoid duplicating hard-coded numbers across the website and faf-java-api, we could replace them with a single source of truth and just go with something like, e.g.:

USERNAME_CHANGE_TOO_EARLY(139, "Username change not allowed", "You are able to change your name again in {0, number} days"),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant