Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check URLs starting with http or https when adding/updating ShortURLs #123

Merged
merged 6 commits into from
Jun 21, 2020

Conversation

Hedlund01
Copy link
Contributor

Issue #100

  • Add validation at creation time in the UI
  • Add validation in AzFunctions

By utilizing data annotations and EditForm, the commits validates the URL at creation time in the UI and returns an explaining message to the user (can be customized).
With the help of the built in function IsWellFormedUriString the commits do the same but for the backend.
I also took the liberty to add a simple modal component to utilize :D

Because the validation checks if its a absolute URL, ftp:// can be passed. I don't know a lot of ftp, so i don't know if this is a security risk or not.

Sorry for the extra commits, branched from master :|

FBoucher and others added 6 commits May 29, 2020 10:41
@FBoucher
Copy link
Collaborator

Wonderful work @Hedlund01!
Thanks you for that nice validation.

@FBoucher FBoucher merged commit ab8b2d3 into microsoft:dev Jun 21, 2020
@FBoucher
Copy link
Collaborator

@all-contributors add @Hedlund01 for code

@allcontributors
Copy link
Contributor

@FBoucher

I've put up a pull request to add @Hedlund01! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants