Skip to content
This repository has been archived by the owner on Mar 25, 2019. It is now read-only.

Rename listener methods #39

Closed
ColinEberhardt opened this issue Oct 16, 2018 · 1 comment · Fixed by #41
Closed

Rename listener methods #39

ColinEberhardt opened this issue Oct 16, 2018 · 1 comment · Fixed by #41

Comments

@ColinEberhardt
Copy link
Member

Currently we have the following:

intentListener(intent: String, handler: (context: Context) => void): Listener;
contextListener(handler: (context: Context) => void): Listener;

In keeping with web conventions (e.g. the DOM addEventListener method), and the standard approach of using 'verb phrases' for method names, I'd propose adding an add prefix to each:

addIntentListener(intent: String, handler: (context: Context) => void): Listener;
addContextListener(handler: (context: Context) => void): Listener;
@nkolba
Copy link
Member

nkolba commented Oct 16, 2018

@ColinEberhardt can you make a PR for this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants