Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddt.offset confusingly commented #141

Open
boeckmann opened this issue Feb 20, 2024 · 1 comment
Open

ddt.offset confusingly commented #141

boeckmann opened this issue Feb 20, 2024 · 1 comment

Comments

@boeckmann
Copy link
Contributor

https://github.com/FDOS/kernel/blob/master/hdr/device.h#L239 states that ddt.offset is the relative partition offset. But in fact this seems to be the absolute LBA sector number of the first sector of the partition.

Initialized here:

pddt->ddt_offset = StartSector;

This is in contrast to bpb_hidden, which is relative to the "container", either the start of the disk or the start of the extended partition:

pddt->ddt_defbpb.bpb_hidden = pEntry->RelSect;

@PerditionC
Copy link
Contributor

I can see that, partition offset relative to start of disk, but absolute lba of start of partition is clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants