Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error screen instead of 404 screen if backend response is 500 #259

Open
jennydaman opened this issue Jan 14, 2022 · 5 comments
Open
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jennydaman
Copy link
Collaborator

No description provided.

@jennydaman jennydaman added bug Something isn't working good first issue Good for newcomers labels Jan 14, 2022
@TateDeVito
Copy link

Hey I'd like to take a look at this! Is there a specific back end response that we want to target?

@jennydaman
Copy link
Collaborator Author

Hello @TateDeVito

There's nothing specific we're trying to target. 500 errors are pretty rare too.

Basically, most of the API requests are unchecked.

const pluginMeta = await this.fetchPluginMeta(pluginName);
const versions = await this.fetchPluginVersions(pluginMeta);
const collaborators = await this.fetchPluginCollaborators(pluginMeta);

So a JavaScript Exception gets thrown and the component fails to load. As a catch-call, the parent Router will show the NotFound component which is a graphic depicting a "404" message. It usually works but can be misleading.

<Route component={NotFound} />

@janvi01
Copy link

janvi01 commented Mar 21, 2022

Hey @jennydaman I want to take up this issue.

@janvi01
Copy link

janvi01 commented Mar 21, 2022

Hey, thanks for assigning. @jennydaman
Please can you elaborate "error screen"? Does it mean displaying an error message?

@JulianaSau
Copy link

Hi, id like to work on this issue

@jennydaman jennydaman assigned JulianaSau and unassigned janvi01 Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants